nitrofmtl / timeout Goto Github PK

I found 3 errors while using this library:

1. void TimeOut::cancel()
   if (TIMEOUT::UNDELETABLE == node->type) does not check that the node is a null pointer.
   This condition occurs if the cancel() function is called twice.

2. TimeOut::handler()
   TimeOut::head->callback(); TimeOutNode *temp = TimeOut::head; if (TimeOut::head->next)

The TimeOut::head is a null pointer if the cancel() function is called in the callback routine of the timer.

3. Calling twice interval()/timeout() function does not change the interval/timeout, it creates another interval/timeout. Should be avoided (error and new timer not created) or handled (automatic cancel of the previous timer)

Hi NitroMtl I apologies but I cant find away to contact you, are you able to tell me if your fork of the Websockets Server will work on my ESP8266 using Ethernet2 and w5500 I cannot seem to get any help from anyone and you seem to be the only person who may have solved the issue

Kind Regards

John

I am trying to make a few minor changes (largely to the manifest and some updates to the readme).

However, I notice that the repository has no license assigned. @NitrofMtl can you let me know what license you would like to use for your code? I can make changes.

But I don't want to add a license for someone else's work :-)

Thanks for the excellent work on this library so far! It was very useful. I would just like to submit it to the PlatformIO library manager as well.

Please comment on line 22, file: https://github.com/NitrofMtl/TimeOut/blob/master/examples/interval_example/interval_example.ino