nitsan-technologies / ns_all_lightbox Goto Github PK

Hi,

since 23. December 2021 this extensions reqeuires TYPO3 core 7.0.0 - 11.5.99. Before it was 7.0.0 - 10.9.99.

The requirements in composer.json however didn't change since ages:

"require": {
"typo3/cms-core": ">=7.0.0"
},

This means that it was suitable for TYPO3 11 before 23/12/2021 and would be suitable for TYPO3 12 in the future, even if it might not be true.

Please narrow your requirements and set a maximum requirement version of the typo3 core. Systems rely on that and other extensions do it, too.

Cheers

Hi!

Configuration/TypoScript/setup.txt causes errors in TYPO3 10 logfile

`Wed, 26 May 2021 12:42:55 +0200 [ERROR] request="7f2f5c82075c0" component="TYPO3.CMS.Frontend.Configuration.TypoScript.ConditionMatching.ConditionMatcher": Expression could not be parsed. - {"expression":"globalVar = LIT:lightbox = 3"}

Wed, 26 May 2021 12:42:55 +0200 [ERROR] request="7f2f5c82075c0" component="TYPO3.CMS.Frontend.Configuration.TypoScript.ConditionMatching.ConditionMatcher": Expression could not be parsed. - {"expression":"globalVar = LIT:fancybox = 3"}
`

Maybe create different setupfiles for old and new TYPO3 or remove support for older version.
Best,
Christoph

When there is a file like "danke_für_alles.jpg" than I get this error, when this extension is active:

(1/2) #1509741907 TYPO3Fluid\Fluid\Core\ViewHelper\Exception

Folder "/user_upload/mitmachen/danke_f%C3%BCr_alles.jpg/" does not exist.

Solution: change this line:
<a href='<f:uri.image src="{file.publicUrl}" maxWidth="{settings.media.popup.width}" maxHeight="{settings.media.popup.height}" />' rel='lightbox[grup{data.uid}]' data-title="{file.description}">
to
<a href='<f:uri.image src="{file.uid}" treatIdAsReference="1" maxWidth="{settings.media.popup.width}" maxHeight="{settings.media.popup.height}" />' rel='lightbox[grup{data.uid}]' data-title="{file.description}">

Hi,

with 5.0.3. the typoscript include name was changed from darkbox to colorbox in these files:

Configuration/TypoScript/setup.typoscript
Configuration/TypoScript/VersionBelow9/setup.typoscript

which leads to log errors:

File "EXT:ns_all_lightbox/Configuration/TypoScript/TYPO3/colorbox.typoscript" was not found.

Please change back to darkbox. ;-)

Hi Sanjay,
Could you let me know how it's possiblle to remove or change the code inserted at the end of the page :

	<script type='text/javascript'>
		$(document).ready(function() {
			$(".fancybox").fancybox();
		});
	</script>

I need to use my own code, because I add in ex. a $(a.fancybox.iframe).xxx instruction.
Thank y ou in advance for your help.
Joel

How can I get an Imagecaption into a Lightbox/Fancybox/etc.? Thank you.

Hi!

Maybe change [compatVersion = 8.7.0] to [compatVersion("8.7.0")] for compatibility in TYPO 10.

BEst,
Christoph

I cannot find partials in the releases 3.1.1 for other media elements than images. In the folders Typo3-7 (under each variant of the lightbox) i can find the partial MediaGallery.html, with 3 case values 3=audioType, 4=videoType and TRUE=imageType.

In the folders Typo3 only Media/Type/image.html with figure class = "image".

Does that mean that this extension only works for media type "image", and are you planning to extend the functionality again to the other media types as well?