nitsan-technologies / ns_gallery

All in One Gallery

All in One Gallery

• Live Frontend Demo: https://demo.t3planet.com/t3-extensions/gallery
• Live Backend Demo: https://demo.t3planet.com/live-typo3/t3t-extensions/typo3/?TYPO3_AUTOLOGIN_USER=editor-gallery
• Free version: https://extensions.typo3.org/extension/ns_gallery
• Premium version: https://t3planet.com/typo3-gallery-extension
• Documentation: https://docs.t3planet.com/en/latest/ExtNsGallery/Index.html
• Changelog: https://t3planet.com/typo3-gallery-extension

ns_gallery's Issues

Preview issue with loading more images

Hey,

I just updated to v2.0.4 but there still seems to be an issue. If you look at the page https://motorsport.adac-sh.de/meisterschaften/adac-nmx-cup/adac-nmx-cup, click on the first "Mehr laden" button and then click on an image that was newly loaded, the preview is at the top of the page and there is no image inside:

Would you mind have a look?

TCA `foreign_types` should not be used

Describe the bug
overrideChildTca should be used instead of foreign_types to define the image palettes. (Deprecation: #80000 - InlineOverrideChildTca)

To Reproduce
Steps to reproduce the behavior:

Create an album with an image property
For the property, `showitem`is falling back to default `basicoverlayPalette` instead of the defined `imageoverlayPalette`

Expected behavior
The image palette should be used

TYPO3 Version
v11.4

Use correct extensionName for translate-VH

In ns_gallery/Resources/Private/Templates/NsAlbum/List.html the translate-Viewhelper is called in that way:
<f:translate key="general.photos" extensionName="ns_gallery" />

The 'extensionName'-parameter is described as:

UpperCamelCased extension key (for example BlogExample)

So, the translation is a bit broken. It's working for the delivered language file, but breaks for overriding via TypoScript. In concrete: the following will not work:

plugin.tx_nsgallery_album {
  _LOCAL_LANG {
    de {
      general\.photos = Bild(er)
    }
  }
}

Solution

1. Remove the (optional) attribute. TYPO3 will have a good fallback chain, so everything works as expected. Or...
2. Set a correct extensionName instead of the extensionKey: <f:translate key="general.photos" extensionName="NsGallery" />

getContentId not set in Google.html template

Hey,

if I use the Google gallery, which uses the ns_gallery/Resources/Private/Templates/NsAlbum/Google.html template, the content id seems not to be set.

Line 8 reads: <div class="GITheWall ajax-{getContentId}" id="ajax-{getContentId}">,
but the HTML source code says: <div class="GITheWall ajax-" id="ajax-"> - the value of getContentId is missing.

In the googleAction of the NsAlbumController, the makeGalleryInitilization() function (which sets the getContentId in the view) is not called. Is that intentional?

Thanks in advance.

More than one Google Gallery on one page

Hey,

is it possible to use the Google Gallery more than once on one page?
It seems that there are errors if I click on one image to open the preview.

The preview window position does not match with the image I clicked on or the height of the preview window is not set correctly and the image is not shown.

Thanks in advance.

Google Fonts and GDPR

Loading Google fonts from Google does not comply to GDPR.
https://github.com/nitsan-technologies/ns_gallery/blob/master/Resources/Public/Css/nsgallery.css#L1