GithubHelp home page GithubHelp logo

Comments (1)

grahamc avatar grahamc commented on July 28, 2024

I started hacking on this, however the mass rebuild checker is a bit sensitive in this area:

  1. We need to be careful either it is safe to call or we don't call find_after on the outpathdiffer if find_before failed
  2. We need to make sure a sensible error message is propagated to the master check if find_before fails, which right now might be complicated.

It might make sense to have the out path checks be a completely separate eval check, that might clean this up. However, it is unique to most of the rest in that it operates on the branch before and after the PR is applied.

However, in the mean time, I have changed the before checking to upload a gist upon failure, so a teeny bit of improvement.

from ofborg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.