Comments (1)
I started hacking on this, however the mass rebuild checker is a bit sensitive in this area:
- We need to be careful either it is safe to call or we don't call find_after on the outpathdiffer if find_before failed
- We need to make sure a sensible error message is propagated to the master check if find_before fails, which right now might be complicated.
It might make sense to have the out path checks be a completely separate eval check, that might clean this up. However, it is unique to most of the rest in that it operates on the branch before and after the PR is applied.
However, in the mean time, I have changed the before checking to upload a gist upon failure, so a teeny bit of improvement.
from ofborg.
Related Issues (20)
- prioritise evaluation for PRs with security label HOT 4
- php component dependencies outdated
- Update `nom` rust dependency HOT 1
- Update `hyper` rust dependency
- `@ofborg test foo` in PR description does nothing HOT 1
- Updating to nix >=2.16 fails during tests
- ofborg fails nondeterministically HOT 6
- Matrix notifications HOT 1
- Build `tests.*` listed as changed paths HOT 2
- Detect what to build based on touched file paths
- Builders sometimes don't have enough space in the build dir for kernel builds
- ofborg does not use `$attr.meta.maintainers` when `$attr` is in the commit message HOT 1
- Update nixpks used in flakes to a current version HOT 4
- How to reproduce jobs locally? -> improve logs HOT 3
- Ping maintainers when they get removed
- generic error: found empty hash, assuming sha256-aaa...
- ofborg doesn't apply changes from PR before kicking off builds on aarch64-darwin sometimes. HOT 3
- error: a 'x86_64-linux' … is required … but I am a 'aarch64-darwin' HOT 3
- Granular requiredSystemFeatures: build individual attributes in passthru.tests HOT 1
- `@ofborg test foo` in a "review comment" does nothing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ofborg.