GithubHelp home page GithubHelp logo

Comments (5)

pbsds avatar pbsds commented on September 2, 2024

You do get a red X in the https://github.com/pulls view when CI fails. Sending messages every time eval fails would cause a storm everytime master fails eval.

from ofborg.

doronbehar avatar doronbehar commented on September 2, 2024

You do get a red X in the github.com/pulls view when CI fails. Sending messages every time eval fails would cause a storm everytime master fails eval.

Correct, but I don't think it is bad. Eval errors on master happen rarely, and when they do, I think it wouldn't hurt to notify many people about it, as it is a severe mistake. Also, even if the error is not due to merges you personally performed, it will also give you the hint to comment @ofborg eval to retrigger evaluation after the eval error is fixed.

from ofborg.

pbsds avatar pbsds commented on September 2, 2024

Doesn't this work?
image

from ofborg.

doronbehar avatar doronbehar commented on September 2, 2024

@pbsds this seems worth checking, but I don't understand how did you get to that interface? I also wonder, why is EditorConfig's workflow notifying me upon emails and ofborg doesn't? The interface you screenshot doesn't look like it has different settings for the above 2 workflows...

from ofborg.

pbsds avatar pbsds commented on September 2, 2024

It may be because the editor config checks run in a github action runner, while the ofborg CI checkmarks are set using some other API by the ofborg runners.

from ofborg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.