njhargis / creamy-cogs Goto Github PK

When a match starts, show champion picture, team comps, make it an embed, etc.

Calling Riot's API is scattered between multiple functions, simplify and consolidate.

Simple command that lists all current active games tracked by the cog.

1. When registering a summoner, add a boolean field to the saved information of whether or not we are checking their live games, default to true.
2. Create a command within leagueset commands that allows you to toggle this flag for yourself.
3. Within check_games, evaluate this flag while looping through registered_summoners.

As an edge case, if we don't find a game ending, let the user automatically end it to clear it from list. Probably should double check against the API.

Check out Red streams cog for example of this.

Is your feature request related to a problem? Please describe.

• I find it difficult to follow log statements across modules when all of the cog modules are named the same

Describe the solution you'd like

• A set format for module-specific logs, such as log = logging.getLogger(red.repo-name.cog-name.module-name)

  • ex. log = logging.getLogger(red.creamy-cogs.leaguecog.blitzcrank)

Nitpicky, but I'm happy to go through and do this. I think we keep going back and forth.

PEP8 on imports... TL;DR:

Imports should be grouped in the following order:

1. Standard library imports.
2. Related third party imports.
3. Local application/library specific imports.

Game type 700

Title

check_games function in Blitzcrank.py currently fails complexity check but it is overridden since it is working at the moment.
Needs refactor, might be solved by #11

Similar to how Blitzcrank handles all API pulling, this would handle all posting to Discord.

Depending on how many registered summoners there are, we should calculate how often we can run the check_games logic without getting close to Riot's throttle limit.
20 requests every 1 second
100 requests every 2 minutes

Anytime new summoner is registered, recalculate.

When closing the match, put it in a pending state. Then determine if they won or lost, and update the embed accordingly.

When this cog is first installed it should force user through a setup.
This setup should help them

1. Setup their API key
2. Let them decide if they want announcements when registered users start games.
3. If they choose yes to 2, help them set an announcement channel.
4. Let user decide if they want gambling on games.
5. If yes and economy is turned off, tell them how to turn it on.

since abc is already a Python module, perhaps rename abc.py to:

• mim.py or mixinmeta.py
• abstract_base_creams.py or the like

https://github.com/meraki-analytics/role-identification