njyoon / njyoon.github.io Goto Github PK

Just reporting: I ran into an encoding issue with the NYT Submission Editor with non-Latin characters (definitely an edge case because the source data is from .puz, which is of course just Latin-1), and upgrading to the latest version of jsPDF (currently 2.5.1) fixed things and did not seem to break anything else.

In case you want to try and repro: in my fork I wrap the title of 21x puzzles in quotes, and I use “ and ” instead of straight quotes. Weirdly they render fine in the default font, but selecting any other font introduces some fun mojibake (þÿ).

Is there a trick to getting the copyright text to display, or is that not the purpose of that option (I can use the subhead or something instead)? I have the copyright option on and have added text, but nothing is visible.

This is interesting, since the footer says "Original code from Crossword Nexus" yet the tool there does support rendering rebuses in the pdf, instead of just the first letter of them. Any chance of seeing support added?

Pretty much what the title says… or at least I think this is what's causing it!!

Thanks a ton for this great, handy tool!

This may be a non-goal of this (excellent) project, but for documentation's sake: the use of URLs relative to the root directory for the CSS and JS files break any fork that is not serving from the root directory. By default with Github, a fork of this repo would live at USERNAME.github.io/njyoon.github.io, and those links will look for e.g. the javascript files at USERNAME.github.io/js/ instead of USERNAME.github.io/njyoon.github.io/js/.

The quick fix I found is removing the leading slash from the src attributes in index.html, nyt.html, and pdf.html. I don't know if there are other knock-on effects but that seemed to work for me.

Incidentally, I forked this to comment out the puz checksum check because some upstream bug produces a checksum mismatch in certain files with lots of circled squares, but I can't figure out exactly what the issue is. I'm going to try to track it down and report it upstream, but in the meantime, I think you could plausibly skip the checksum check or change the error it throws to a console warning.

Just wanted to say that it would be wonderful to see support for ipuz, an open, free, extensible format for crossword puzzles!