nmaguirre / eiffel-sudoku Goto Github PK

The implementation of routine make_with_value in class SUDOKU_CELL is missing.

do not use "create" to use the "make" and in each cycle creates a new "cell" and assigns it to the board in the position

Implements the routine unset_cell in SUDOKU_BOARD class.

We need to create the board. Hence a model.make would seem to be perfect, but for some reasons, it doesn't work. It seems that we are going out of the sudoku board range.

There's not any configuration which make Is_valid true but cannot make Is_complete routine (from the same class) true ?

The implementation of routine make in class SUDOKU_CELL is missing.

Routine make in class SUDOKU_CELL has no contracts. Pre and postconditions for this routine must be provided.

When you modify a cell on the board only the board from the GUI change.
It would be nice if both boards where connected. Without that we cannot use, for example, the initialization of SUDOKU_BOARD in the MAIN_WINDOW

Routine set_value in class SUDOKU_CELL has no contracts. Pre and postconditions for this routine must be provided.

last row doesn't show correctly

In Cell text field, row and col were never assigned.
I added a procedure Set_Position to the Cell_Text_Field, and in Windows I set cells' row and column values at creation with this procedure.

Implements the routine set_cell in SUDOKU_BOARD class.

Class SUDOKU_BOARD has no summary. An appropriate, short summary for this class must be provided, and put as part of the header of the class.

Routine make_with_value in class SUDOKU_CELL has no contracts. Pre and postconditions for this routine must be provided.

The number should be between 1-9 and in the same column, row and square the number doesn't exist.

Normally, blocks of 3x3 are separated more clearly from the others.
We should increase the gap between those blocks or insert a black line if possible.

Routine unset_cell in class SUDOKU_BOARD has no description. A brief description, given as a comment at the beginning of the routine, must be provided.

change scope feature initialization, {NONE} for {ANY}

Routine set_cell in class SUDOKU_BOARD has no description. A brief description, given as a comment at the beginning of the routine, must be provided.

We need a function in Sudoku_Board capable of giving a feedback to the controller which in turn would be able to give a feedback to the GUI.

Example : After creation of the sudoku_board we need to put in the GUI the values of the cells hence, we need getters

No tests are provided for routine set_value in class SUDOKU_CELL. At least two tests must be provided for this routine (considering negative tests too), and put into class SUDOKU_CELL_TEST_SET.

I use the method "get_value" SUDOKU_CELL class to get the value of the cell

The implementation of routine set_value in class SUDOKU_CELL is missing.

Routine make in class SUDOKU_BOARD has no contracts. Pre and postconditions for this routine must be provided.

Reads boards value and set them in the gui's cells

Class SUDOKU_CELL has no invariant. An invariant for this class must be provided.