Select multiple buildings by clicking on campus areas about cella

[sumnerwarren]

I'm working on this right now. I've got the CSS working properly. Just need to get the behavior down now.

[nmalkin]

Cool!

[sumnerwarren]

56f17988d7 This should take care of this. The only thing that bugs me is that Chosen automatically highlights the first item when a field is clicked in. This is fine for occupancy, but I think it looks kind of strange for buildings where the group name can be selected as well. I can pretty easily change this to not select anything, or to select the first group. What do you think?

[nmalkin]

Looks great! Thanks!

I agree about the automatic highlighting being excessive. I think no highlighting would be preferable.

[nmalkin]

One minor issue that I noticed is that the highlighted .group-select is slightly taller than the not-highlighted one, so when you hover over a campus area, all the buildings in it shift down a little bit.

[sumnerwarren]

fb7576fb32 Okay, initial highlights are gone. The one pixel shifting is due to the text that's being added on mouseenter. If I raise the baseline of this text by one pixel, the height doesn't change like it did, but I think it's pretty obvious. Maybe we don't need the text?

[nmalkin]

Initial highlights are gone in Chrome, but seem to sometimes appear and sometimes not appear in Firefox. Can you reproduce this? (I'm on Firefox 11.)

You're right about the baseline difference being noticeable. I'd vote for getting rid of the text, but I feel like I might be biased as a "pro" user. Do you think it would hurt usability?

[sumnerwarren]

7dc26744da I think the text should be there, and I was able to fix the baseline issue. Still working on the highlights some more. They are triggered by a mousedown or click in the filter box, and when I try to to undo them, it has to be through an explicit trigger. So it's a race to see if the drop down opens before the highlight is erased. Don't know what to do about that. For someone reason, it never shows up in Chrome as far as I can tell, but does in Firefox quite frequently.

[nmalkin]

Yeah, right now it flickers in Firefox: highlights then immediately un-highlights.

Nice fix for the baseline issue. I'm still against the text, because I think the interface provides enough of a clue to the behavior. (Over campus areas, the cursor changes and the item highlights, just like for buildings. So it makes sense that you can select them, just like buildings.) But I'm okay leaving the text in for now.

[sumnerwarren]

a079151a55 Okay, text gone. I think you're right, it's fairly obvious they can be selected. On the highlighting subject, I can't figure out an external solution. I could edit Chosen and remove that highlight call; it doesn't affect anything else. But I don't think we really want to do that, do we?

[nmalkin]

It's not worth it. Let's live with the automatic highlighting.

[sumnerwarren]

c68088cbb6 Back to automatic highlighting. Don't close this one just yet. I noticed a weird behavior. If you select one of the actual items and then click in the filter box again, it displays the list again. However, if you select a group and then click in the box, it won't display. You have to make the box lose focus and then click in it again in order for it to display. Should be a pretty easy fix.

[sumnerwarren]

9643bcb887 Fixed the weird behavior I was noticing. It was extremely simple, but eluded me for a long time. Noticed that because queries are served every time a change is called on the base select element, one was being fired for each building which was added when selecting a campus area. I added a new global variable to keep track of when a group was selected, and the filterChanged function only looks for rooms if a group select is not in process, which means I trigger a change event at the end of a group select. Acceptable?

[nmalkin]

(0575684) Ah, nice find. Yeah, the global variable is totally acceptable. It's the simplest and probably the best solution.
It tests well on my end, so if you're happy with it, feel free to pull request.