nmalkin / cella Goto Github PK

To reproduce:

1. Generate some rooms
2. Star some of them
3. Go to star tab
4. Reload

When page is reloaded, the starred rooms will appear in this tab, but the probabilities won't be set.

This is a consequence of the current implementation, in which starred tabs are "re-starred" on load after a timed delay, which happens after the initial activateTab call has been made (which would calculate and load the probabilities).

For each room, provide the possibility of seeing how it did in previous years -- what was the lottery number of the group it went to.

Current idea: display this information in a popover.
Alternate ideas welcome.

To reproduce (example):

1. Set occupancy to 1.
2. Set building to "Barbour Hall"
3. (Results will be loaded)
4. Clear occupancy by clicking the "x" next to the 1.

Bug: On some occasions, the results will still appear in the table.

If this doesn't reproduce it, setting and un-setting the occupancy to 1 several times usually ends with this result.

Stepping through step-by-step appears to show the table being cleared (as it should be), but the results reappear at the end of the call.
Strangely, I could not produce a similar behavior with the other select (buildings).

Bug reproduced using:

1. Google Chrome 16.0.912.75 (on OS X 10.6.8)
2. Safari 5.1.2

Bug could not be reproduced with:

1. Firefox 11

It seems like the probabilities are not updating until the slider is moved a second time. If you start a new session, and get some results, then move the slider once, nothing happens. If you move it again, then the probabilities change. This only occurs if I don't actually move the slider, but instead click to a new value. If I click to a second new value, they update. Actually moving the slider does change the probabilities as expected. This may just have to do with the way the slider fires events?

This is a major bug, going a while back.

To reproduce:

1. Add some rooms
2. Set probability to low value (so that it's noticeable)
3. Add some more rooms to this list

You'll notice that all the new room display an unexpectedly high probability.

The problem is that (to prevent re-computation), we only update probabilities when the lottery number has changed. However, new rooms, when added to the results table, carry a default probability value -- not based on the currently selected lottery number -- and their values are not being updated.

Adding rooms to the star tab does not make the message Starred results will appear in this tab. go away.

When entering input into the select box, the form suggests completions for building names, but not for campus areas. (This is because of the custom behavior we created for #1 to enable the selection of campus areas.)

Right now, the result filters (the dropdowns for occupancy, buildings, etc.) are located in the header of the results table. This gets somewhat unwieldy when there are lots of values selected. Perhaps it would be better if the filters were located outside the table?

Right now, when a new tab is created, it is automatically activated, but those two actions should be separate. This is primarily relevant on startup, when multiple new tabs may be created, but none of them, except the last active one, should be activated.

Currently loaded from server every time new tab is created.

b872bd25aa I've been working on this lately. Let me know what you think of this. If you set the lottery number to 78, occupancy to 1, and add Gregorian Quad A, you can see all five colors together. I don't really care for the orange or yellow, and the two greens might not be different enough. Maybe you have suggestions or alternatives for these? I'm having trouble with the text. With some work I could get it centered in the bar, which I think is the best option. Right now it follows the right edge of the colored section. Or is it necessary? Could we get away with a tooltip, or nothing?

We should consider having a welcome message for first-time visitors that briefly describes the point of the app. Like the about box, it should be collapsible.

"Gender-neutral singles" is not a meaningful concept. As such, we probably don't need to display that tag for rooms of occupancy 1.

First need to decide how we're presenting this information. Suggestions have included putting it in a sidebar or opening the floorplans in a separate search tab. Or we could just have a link to it.

...to an incorrect value

To reproduce:

1. Check "include sophomore-only housing"
2. Set lottery number to 800 (any noticeable value will do)
3. Select occupancy 2
4. Select Caswell Hall
   Note: probability is displayed correctly.
5. Now toggle sophomore checkbox off and back on

Expected:

• Probability values remain the same.

Actual:

• Probability values are all reset to the same value (~80%).

The following rooms are identified with labels:

• sophomore-only
• gender-neutral
• apartment-rate

Right now, they're all the same boring barely-noticeable gray color. Each should have its own color.

The sticking point is the choice of colors. Suggestions?

(Limitation: I want to reserve the "built-in" red, yellow, green, and light blue colors for other potential uses.)

Toggling the sophomore status checkbox triggers an update of the rooms in the current tab. However, rooms in other tabs may be affected too. Those results should be updated as well.

Explain that all data is stored in the browser; we store nothing server-side.

It works, but not always. The problem is that, when rooms are starred, TableSorter isn't notified of the update, so it doesn't take their new status into account when trying to sort. (After something else causes update to be triggered, the sorting works.)

Right now, searches when no occupancy is selected go through and return no results. Rather than doing this and then displaying a generic "no results" message, we should identify this situation, prevent the extra call to the server, and display a customized message.

To use the screen more efficiently, the "about you" box should be collapsible.

I'm thinking that clicking on the text "about you" should make the box slide up (leaving just the text) and then slide down when clicked again.

This setting should probably be persistent.

...would be a nice feature. Would need to be careful about how it would interact with #5, primarily with respect to #2.

...otherwise, they're not likely to find out. (Right now, you have to read the about page to know.)

Simplest way is probably to add a note at the bottom of the page.

Perhaps better is to add an easily identifiable cue ("drag handle") to the results.

Right now, when the result table is populated, the rooms are placed in the same order they are in the database. It would be better if the order they appeared in were more sensible.

I think the most reasonable arrangement is for them to be sorted by building and then by room number.

Any better alternatives?

i.e., explain that we don't draw a distinction and just go based on occupancy

Include only the parts of the jQuery UI library that we actually use.

In the upcoming housing lottery, there will be rooms that have no history in the housing lottery (e.g., Hope, Littlefield, Thayer Street dorm). There's nothing meaningful we can display for their probability, so there should be some placeholder instead of their probability bar, most likely with a popover that explains that we have no results for them.

Multiple people have expressed confusion over the wording of the sophomore-status checkbox ("I am a sophomore"). Change it to something less ambiguous, like "Include sophomore-only housing".

As the star tab placeholder appears if and only if no tabs are starred, so there should be a placeholder whenever a table is empty.

This can be the same, or different from, the currently used placeholder saying "no results yet", which appears only before any filters have been changed.

The star glyph is smaller than it was before (and is in other browsers) in Firefox 14.

When tabs and room results are loaded from local storage, they are displayed in the original order of the results, not the order that they were in after sorting.

In addition to clearing persistent data, should reload the page. This should make more sense to users.

(Also, have a confirmation button before actually doing it.)

We probably want Mocha-style sharing: provide a URL from which the starred rooms will be loaded into the application.

It would be nice if clicking on a campus area resulted in the selection of all the buildings in it. (Right now, it does nothing.)

Unfortunately, Chosen, the library used for the building selectors, doesn't support this out of the box, so implementing this would likely require hacking on top of it.

As described here. If we implement this, there should probably be a "loading" message (distinct from the startup loading message, i.e. #11).

See comment here

It should be possible to sort the table of starred rooms like all the other result tables.

Some helpful resources here

Right now, the tabs for each search just display the search number. That's not too useful. We should make them more so.

One possibility is to display what the search is in each title. (e.g., "Singles in Minden")
The problem with this is that if you have more than one building (likely), the tab gets too big.

An alternate, less satisfying, possibility is to display the same information in a tooltip when hovering over the tab.
This suffers from a similar problem, though.

We could let users give custom names to tabs (e.g., double-click to change title). Not really sure what the use case for this would be, though.

As always, open to input.

To reproduce:

1. Select occupancy "1"
2. Click on the star (triggers sorting)

Result:
The new tab placeholder message ("No results yet!...") appears underneath the standard no-results placeholder message, even though it had previously been deleted.

This sometimes appears under other circumstances (with results present), also when sorting by the star column. Replicated across browsers.

When the application is starting up and loading a lot of previously saved rooms, it takes a noticeable time to do that, so it would be nice to have some text and maybe a basic animation (e.g., spinner) telling people to chill, content is loading, this'll take a couple of moments.

"Apartment Rate" would link here, "Gender-Neutral" would link here, and so on.

Other potential targets could be the floorplan for the room or the room review.

When the tab is changed, the probabilities of all rooms in the newly activated tab are updated. However, this only needs to be done if the lottery number has changed since the last time this tab was open.

As seen from the online projection and list of rooms (warning: .xls).

Where did I get 5?

Sorting the result table by probability does not produce meaningful results.

Choose any occupancy or combinations of. If you add all buildings to the filter and set the mode to 'Exclude', no results should be returned, correct? This is not the case. If sophomore-only is unchecked, then it seems like all sophomore-only results still show up in the results table. If you then check sophomore-only, they disappear, which is expected. Uncheck it, and they show back up. Seems like something is wrong with the logic there.

Twitter Bootstrap version 2.0 has been released, so it might be useful to upgrade to it at some point.

The changes are described here. They include:

• renaming (topbar -> navbar)
• 16 columns -> 12 columns
• JavaScript plugins updated, new syntax
• "Dropped support for TableSorter"

I'm not sure what the last one entails, but if any will cause us problems, this is the more likely one.

Some sequence of operations (not sure how to reproduce ATM) results in rooms being added to the table that have an ID of -1. This shouldn't happen (obviously), so we should probably be stricter about checking these things.

Since we don't work without JavaScript, we should have a noscript message displayed to users without JavaScript.