nnoggie / mythicdungeontools Goto Github PK

Level slider doesn't work when a certain amount of pulls or more have been created and the frame is scrolled through.

Reproduce Steps:

1. Create 14 Pulls
2. Scroll to bottom and select 13th
3. Try to change level of Key

If you zoom in (i.e. EoA) and then switch the dungeon you stay zoomed in. If you now switch to a smaller map/dungeon its still zoomed in. Kinda confusing and not very accessible

The first set of mobs in EoA are mispositioned.

Wandering Shellback 1
Wandering Shellback 2
Hatecoil Warrior 1
Hatecoil Warrior 2
Hatecoil Wrangler 1
Hatecoil Stormweaver 1
Hatecoil Warrior 3

Most of them are just shifted to the left quite a bit. See screenshots below for the way they're setup.
https://gyazo.com/ac99a7694c98d3d94ca54f30af447d27
https://gyazo.com/f6db609c4cf03e74befe69f95df6d883

When creating a new preset, the option 'Use as a starting point' doesn't appear to do anything. I assume the option is supposed to "make a copy" of the selected preset but with a preset name that can be used as a template or starting point. This currently doesn't seem to work at all and just creates a blank template regardless of which preset is selected.

Depending on the dungeon you get a chat prompt with a number.

https://gyazo.com/40c16c7486a363f3b5cabdb5af3e9f6d

After creating 30 different pulls and realizing that I need more % it is quick frustrating to add a pull in the middle of the dungeon.

Currently you have to a a new pull #31
then right click move up one
until you get it to the desired space
repeat.

I suggest that I can just click a pull and drag it to the allocated area.
or if I am clicked on pull 22 and click add new pull it creates #23 and moves the rest by one number.

I noticed the following Lua-Error that apparently occured while i did a LFG-Dungeon (Outland) on an lowlevel alt. Nothing major, probably not even worth a fix, but you probably like bugfree code so hit it hard and with fire. Occures on MDT v2.1.9.2 (Twitch client)

13x ...aceMethodDungeonTools\MethodDungeonTools-2.1.9.2.lua:148: attempt to index field 'main_frame' (a nil value)
...aceMethodDungeonTools\MethodDungeonTools-2.1.9.2.lua:148: in function <...aceMethodDungeonTools\MethodDungeonTools.lua:146>
(tail call): ?

Locals:
self = {
0 =
}
addon = nil
inGroup = true
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'main_frame' (a nil value)"
MethodDungeonTools =

When planning a route in upper karazhan, it seemed very strange since the addon told us that we need ALL of the Mana Devourers after the third boss, to be even close to 100%. We then ran the dungeon with the planned route (https://pastebin.com/aN61aSYA) and ended up with way above 100%.

(This might be a similar problem to Issue #25)

The two mobs "Shieldbearer of Zul" in the lower right, who both give 0 enemy forces, are linked to the pack directly before Vol'kaal. The screenshot illustrates them by their numbers showing on their icons as I point the cursor at them. Selecting either location of adds will also select the entire group on the opposite side of the instance.

If this is intentional then I apologise but it seemed strange so I reported it.

As the title says:

2x MethodDungeonTools\Transmission.lua:75: attempt to get length of local 'str' (a nil value)
MethodDungeonTools\Transmission.lua:75: in function decodeB64' MethodDungeonTools\Transmission.lua:107: in function StringToTable'
...aceMethodDungeonTools\MethodDungeonTools-1.4.2.lua:2050: in function <...aceMethodDungeonTools\MethodDungeonTools.lua:2049>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[4]"]:9: in function <[string "safecall Dispatcher[4]"]:5>
(tail call): ?
Ace3\AceGUI-3.0\AceGUI-3.0-34.lua:314: in function `Fire'
...dOns\Ace3\AceGUI-3.0-34\widgets\AceGUIWidget-Button.lua:22: in function <...dOns\Ace3\AceGUI-3.0\widgets\AceGUIWidget-Button.lua:19>

Locals:
nil

Dungeon: Cathedral of Eternal Night.
Zone: The Emerald Archives.

When you try to select a pack of imps or scanvegers it selects both left and right and the patrollers.

Before clicking

After Clicking

In Upper Karazhan you have counted the Boss "Mana devourer" as a mob aswell and it shows up in Upper Library so the Mob Count is not correct.

First one is with the Extra add (Boss)

https://gyazo.com/26b4fce3ff4e7cac7fba4953f8e7849b

Second one is without Extra add (Boss)

https://gyazo.com/57ab1c92f5cd1bef90a23194e54fca1e

Side note: Awesome addon and keep it up!

the fps dropped low and the ping gone high when i entered a mythic dungeon, like it killed my pc

...should be gone or at least has a close option. Well it should be gone.

Visually the tooltips look fine but they seem to throw up .lua errors with ElvUI enabled.
There are no issues if ElvUI is disabled, but it's a popular UI addon so this could potentially affect a lot of users. An error fires off for every tooltip event, leading to the game recommending addons be disabled due to the volume of errors. It happens when you mouse over an NPC, generating a tooltip. The error fires off once upon the tooltip appearing and does not recur until you mouse over another NPC on the map.

Message: ...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1241: attempt to index field '?' (a nil value)
Time: Wed Jul 25 17:17:59 2018
Count: 3
Stack: ...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1241: attempt to index field '?' (a nil value)
(tail call): ?
...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1241: in function <...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1239>
(tail call): ?
...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1831: in function UpdatePullButtonNPCData' ...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1900: in function ReloadPullButtons'
...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1492: in function <...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1477>
...Ons\MethodDungeonTools\BattleForAzeroth\Freehold.lua:52: in function UpdateMap' ...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1518: in function UpdateToDungeon'
...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1438: in function <...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1431>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?
...ace\AddOns\HandyNotes\Libs\AceGUI-3.0\AceGUI-3.0.lua:314: in function Fire' ...es\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:442: in function <...es\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:433> (tail call): ? [C]: ? [string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5> (tail call): ? ...ace\AddOns\HandyNotes\Libs\AceGUI-3.0\AceGUI-3.0.lua:314: in function Fire'
...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:351: in function <...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:341>

Locals:

and

Message: ...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:2474: attempt to index field 'Tooltip' (a nil value)
Time: Wed Jul 25 17:23:44 2018
Count: 1
Stack: ...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:2474: attempt to index field 'Tooltip' (a nil value)
[C]: ?
...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:2474: in function <...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:2470>
[C]: in function Show' ...ace\AddOns\MethodDungeonTools\MethodDungeonTools.lua:1079: in function ActivatePullTooltip'
...nTools\AceGUIWidget-MethodDungeonToolsPullButton.lua:46: in function <...nTools\AceGUIWidget-MethodDungeonToolsPullButton.lua:37>

Locals:

Well right now you cant add mobs to a boss pull. But sometimes you wanna pull mobs into a boss

We just did a VotW key, and at one point the score from AngryKeystones didn't match the score of the mdt addon.
we pulled 6 mobs (see below) and expected to obtain 24 score, but we gained only 16 score.

Going through the video (clip: https://www.youtube.com/watch?v=E_KX-9p2ae8) i saw, that both fel-infused furies did not add any count when they died (5 sec and 9 sec, you can go frame by frame with "," and "." on youtube). Is the addon wrong, did we encounter a bug or do they really give no count?

downloaded the addon on my laptop to test some stuff while "at work", but i cannot start the addon.

errors on logging in and reloading (all other addons except mdt, bugsack and buggrabber disabled, english client):
error 1: https://pastebin.com/CAT17sYU
error 2: https://pastebin.com/z5LWchqy

errors on typing /mdt and pressing enter ONCE:
error 3: https://pastebin.com/cjHeRws1
error 4: https://pastebin.com/vb75AF46

while pressing enter, the chat-line doesnt disappear (the /mdt i typed) and the addon opens (though without any visible map, see below). pressing enter a second time closes both the addon and the chat-line.

error 4 seems to be the same error as posted in #18, but since i got additional errors i opened a new issue. the map isnt showing either. error 4 seems to appear ~ 10 times per second while hovering over the location where the map should be (the now transparent area of the addon).

map not visible:

Might seem confusing to have both in the same window

Thrown errors when rightclicking the "oldest" pull

2x ...aceMethodDungeonTools\MethodDungeonTools-1.lua:2146: bad argument #1 to 'pairs' (table expected, got nil)
[C]: in function `pairs'
...aceMethodDungeonTools\MethodDungeonTools-1.lua:2146: in function `SetSelectionToPull'
...aceMethodDungeonTools\MethodDungeonTools-1.lua:2296: in function `DeletePull'
...nTools\AceGUIWidget-MethodDungeonToolsPullButton.lua:82: in function `func'
...UI\Libraries\LibUIDropDownMenu\LibUIDropDownMenu.lua:819: in function `L_UIDropDownMenuButton_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals:
(*temporary) = nil
(*temporary) = "table expected, got nil"
= <function> defined =[C]:-1

8x ...aceMethodDungeonTools\MethodDungeonTools-1.lua:2104: bad argument #1 to 'pairs' (table expected, got nil)
[C]: in function `pairs'
...aceMethodDungeonTools\MethodDungeonTools-1.lua:2104: in function `SetMapSublevel'
...nTools\AceGUIWidget-MethodDungeonToolsPullButton.lua:25: in function <...nTools\AceGUIWidget-MethodDungeonToolsPullButton.lua:17>

Locals:
(*temporary) = nil
(*temporary) = "table expected, got nil"
 = <function> defined =[C]:-1

using version b70d5b5

Might be a bug. For example, you have first pull that contains 2 mobs, When you add another pull and choose the same mobs (feels strange that you can do that), if you delete the 2nd pull because its unnecessary, the first one bugs out and doesn't give any count. More than that, it just makes the initial pull empty.

The Feasting Skyscreamers shall be able to cast Bulwark of Juju, which they don't do at least.

Best regards,
Dradux

when moving the clear dialog frame ,the text _Delete presentname?_didn't move with the dialog.The present name also wrong too.

Can't reproduce it right now. Somehow created a empty pull. Maybe i was clicking to fast. Added mobs to a pull and wanted to delete the pull.
Got 7 lua-Errors
https://pastebin.com/8sB1AftM

The small crawlers in the red and blue area can be pulled separately from the black ones. i dont't know the exact linking of the mobs, but these 4 can be easily pulled in a 3+1 fashion.

these crocodiles are also not completely linked

When I switched from any dungeon to Lower Kara it throws an error (linked below) and also keeps the mob count I did from the dungeon on the side.

BugSack: Link
Example: Streamable

Add a Minimap Button with the Method logo to open/close the addon.

Hey,
I used MDT for the spell ID's to create all my WA's. I found that Lord Stormsong shall have a spell called "Mystic Touch", which does exactly the same as the Monk debuff does. Pretty sure, that there something went wrong and it shouldn't be there. Haven't tested it, but it does matches the style of his other abilities.

Best regards,
Dradux

when hovering over the lower mob:

when hovering over the upper mob:

same with other mobs:

No map/textures
https://i.imgur.com/CRA1Emo.png

A cycling error on opening of MDT
https://pastebin.com/deLtD78U

Add info to mob tool tip like dangerous casts. CC Immunity and stuff.
I think this will greatly increase the user base since imo there will be alot of users that dont pre plan pulls (or use preset pulls if that is planned) but need info about specific mobs to focus/care about/how to handle them.
I dont know where you wanna go with that addon. I think that is alot of work and goes more toward some kind of m+ compendium.

Its not about the missing model. But would be nice to see the boss hp scaling with keystone level. So you can predict if you get a 2nd cd or such

So, I have a couple ideas about the UI but those are very trivial compared to ones below:

• The ability to highlight crowd control and stun rotation on each pull, along with interrupts. In example, mob A will get imprisoned by the demon hunter; warlock will banish mob B and the shaman will stun first the rest N and then etc. That means you could also have specific interrupt rotations (sephuz procs i.e.) for specific pulls in order to achieve maximum DPS.
• Calculate the minimum required party DPS for each pull given the pull's time length beforehand set by the leader when he is planning the dungeon. This way, you can actually grasp on what truly limits you going higher and how truly DPS cooldowns can be abused in harmony with each other so maximum performance is achieved.
• Combining both ideas above leads to also highlight DPS and healing cooldowns (i.e. battle cry, combustion, trueshot) on each pull for the same reasons explained above.

When people want to push high, they sit down and try to calculate the best course of action, from the first pull till the last; they always try to find different ways to approach the pathing. Having the features above would feel very good.

Help Frames for:

• Main Map Frame
• Enemy Blips (explaining colors,linked NPCs,CTRL click)
• Preset Selection
• New, Export, Import, Rename, Clear, Delete Buttons
• Pull Buttons

If everyone crosses the bridge on the right side, you only get 2 Falkes. Doing this is the high key pull pattern for many groups. I don't know how pedantic to be for things like this since they don't offer count, but might be worth disconnecting them into 2 groups.

When importing a custom preset, if you have a different dungeon selected then the one being imported, an error is thrown. ex: Create preset for Halls of Valor then export. Select Black Rook Hold as the current dungeon, then click the import button and import the preset for Halls of Valor.

The error being thrown:

1x MethodDungeonTools\Transmission.lua:75: attempt to get length of local 'str' (a nil value)
MethodDungeonTools\Transmission.lua:75: in function decodeB64' MethodDungeonTools\Transmission.lua:107: in function StringToTable'
...aceMethodDungeonTools\MethodDungeonTools-1.lua:1920: in function <...aceMethodDungeonTools\MethodDungeonTools.lua:1919>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[4]"]:9: in function <[string "safecall Dispatcher[4]"]:5>
(tail call): ?
Ace3\AceGUI-3.0\AceGUI-3.0-34.lua:314: in function `Fire'
...dOns\Ace3\AceGUI-3.0-34\widgets\AceGUIWidget-Button.lua:22: in function <...dOns\Ace3\AceGUI-3.0\widgets\AceGUIWidget-Button.lua:19>

Locals:
nil

If you click the okay button after pasting the import code, then press the import button, a separate error is thrown:

4x ...aceMethodDungeonTools\MethodDungeonTools-1.lua:745: attempt to index field '?' (a nil value)
...aceMethodDungeonTools\MethodDungeonTools-1.lua:745: in function UpdateEnemiesSelected' ...aceMethodDungeonTools\MethodDungeonTools-1.lua:2087: in function SetSelectionToPull'
...aceMethodDungeonTools\MethodDungeonTools-1.lua:1777: in function UpdateMap' ...aceMethodDungeonTools\MethodDungeonTools-1.lua:1949: in function ImportPreset'
...aceMethodDungeonTools\MethodDungeonTools-1.lua:1922: in function <...aceMethodDungeonTools\MethodDungeonTools.lua:1919>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[4]"]:9: in function <[string "safecall Dispatcher[4]"]:5>
(tail call): ?
Ace3\AceGUI-3.0\AceGUI-3.0-34.lua:314: in function `Fire'
...dOns\Ace3\AceGUI-3.0-34\widgets\AceGUIWidget-Button.lua:22: in function <...dOns\Ace3\AceGUI-3.0\widgets\AceGUIWidget-Button.lua:19>

Locals:
nil

A final note: Sometimes the preset is actually imported successfully; thus creating a preset for the incorrect dungeon.

The minimap icon and the slash command to pull up the Dungeon Tool are not working anymore. Re-install did not fix it, and I'm not sure where this addon stores its saved info to delete the cached info.

A selection frame to select the output channel for mob abilities etc. (as in details) would be sick.

Before assigning groups to any pull:

After assigning group A to pull A:

After assigning group B to pull B:

After selecting pull A in the list:

Assigning groups to different pulls doesn't make sense, but i got confused because certain groups were not highlighted green, even though they were assigned to a pull (they were assigned to multiple pulls by accident).
If you then delete pull B from the list, pull B gets deleted and pull A gets cleared (reference to #3)

I've noticed percentages end at 150 and mob that gives 8% usually gives 12% instead. Why is this scaled up like this?

There is a little gap between header and map

Pulls arent aligned corretly in the pull frame as well the pull frame itself

I dont know if thats and elvui thing. And if I should stop those issues til the addon gets final :D

If i am not completely mistaken, there is a Spectral Journeyman missing.

die HP-Anzeige der Mobs weicht bei mir und einem Gildenkollegen voneinander ab - ich habe die Pulls erstellt (Screenshot1) und der Kollege hat meine erstellen Pulls importiert. Wir haben beide das AddOn heute erst heruntergeladen und erstellt.


das tritt allerdings nicht nur bei den jetzt im Screenshot aufgeführten Mobs sondern bei allen - auch in anderen Instanzen

As the title says. If pull 1 is the last pull in the list and then gets deleted, it returns an error. Doing this with mobs assigned can also lead to further errors. I caused this error on my default profile for Upper Kara, and now the whole preset is bugged and can't be deleted. Assuming I'll need to clear my saved variables for that default.

3x ...aceMethodDungeonTools\MethodDungeonTools-1.lua:2250: attempt to index field '?' (a nil value)
...aceMethodDungeonTools\MethodDungeonTools-1.lua:2250: in function PickPullButton' ...aceMethodDungeonTools\MethodDungeonTools-1.lua:2137: in function SetSelectionToPull'
...aceMethodDungeonTools\MethodDungeonTools-1.lua:2296: in function DeletePull' ...nTools\AceGUIWidget-MethodDungeonToolsPullButton.lua:82: in function func'
...onTools\libs\LibUIDropDownMenu\LibUIDropDownMenu.lua:814: in function `L_UIDropDownMenuButton_OnClick'
[string ":OnClick"]:1: in function <[string ":OnClick"]:1>

Locals:
self =

{
ClearPull = defined @MethodDungeonTools\MethodDungeonTools.lua:2263
UpdateEnemyBlipSelection = defined @MethodDungeonTools\MethodDungeonTools.lua:846
MakeMapTexture = defined @MethodDungeonTools\MethodDungeonTools.lua:965
OpenNewPresetDialog = defined @MethodDungeonTools\MethodDungeonTools.lua:1700
MakeRenameFrame = defined @MethodDungeonTools\MethodDungeonTools.lua:2309
ToggleDevMode = defined @MethodDungeonTools\MethodDungeonTools.lua:393
CreateDungeonSelectDropdown = defined @MethodDungeonTools\MethodDungeonTools.lua:1760
PresetsDeletePull = defined @MethodDungeonTools\MethodDungeonTools.lua:2076
dungeonMaps = {
}
CreateDungeonPresetDropdown = defined @MethodDungeonTools\MethodDungeonTools.lua:1734
AddPull = defined @MethodDungeonTools\MethodDungeonTools.lua:2255
MovePullUp = defined @MethodDungeonTools\MethodDungeonTools.lua:2271
main_frame = MethodDungeonToolsFrame {
}
StringToTable = defined @MethodDungeonTools\Transmission.lua:104
PresetsSwapPulls = defined @MethodDungeonTools\MethodDungeonTools.lua:2084
SanitizePresetName = defined @MethodDungeonTools\MethodDungeonTools.lua:1910
PickPullButton = defined @MethodDungeonTools\MethodDungeonTools.lua:2247
HideInterface = defined @MethodDungeonTools\MethodDungeonTools.lua:389
CreateTutorialButton = defined @MethodDungeonTools\MethodDungeonTools.lua:2425
MakeDeleteConfirmationFrame = defined @MethodDungeonTools\MethodDungeonTools.lua:2388
MakeExportFrame = defined @MethodDungeonTools\MethodDungeonTools.lua:2360
dungeonBosses = {
}
CalculateEnemyHealth = defined @MethodDungeonTools\MethodDungeonTools.lua:1454
ShowInterface = defined @MethodDungeonTools\MethodDungeonTools.lua:377
MakeSidePanel = defined @MethodDungeonTools\MethodDungeonTools.lua:493
RenamePreset = defined @MethodDungeonTools\MethodDungeonTools.lua:2301
DeletePreset = defined @MethodDungeonTools\MethodDungeonTools.lua:1874
DeletePull = defined @MethodDungeonTools\MethodDungeonTools.lua:2287
MovePullDown = defined @MethodDungeonTools\MethodDungeonTools.lua:2279
dungeonTotalCount = {
}
ADDON_LOADED = defined @MethodDungeonTools\MethodDungeonTools.lua:148
UpdateDungeonEnemies = defined @MethodDungeonTools\MethodDungeonTools.lua:1525
contextMenuList = {
}
MakePresetCreationFrame = defined @MethodDungeonTools\MethodDungeonTools.lua:1925
DisplayEncounterInformation = defined @MethodDungeonTools\MethodDungeonTools.lua:1474
dungeonEnemies = {
}
UpdateSidePanelCheckBoxes = defined @MethodDungeonTools\MethodDungeonTools.lua:1720
UpdateEnemiesSelected = defined @MethodDungeonTools\MethodDungeonTools.lua:743
FormatEnemyHealth = defined @MethodDungeonTools\MethodDungeonTools.lua:1462
SetMapSublevel = defined @MethodDungeonTools\MethodDungeonTools.lua:2100
UpdateMap = defined @MethodDungeonTools\MethodDungeonTools.lua:1814
MakePullSelectionButtons = defined @MethodDungeonTools\MethodDungeonTools.lua:2032
UpdatePullButtonNPCData = defined @MethodDungeonTools\MethodDungeonTools.lua:2175
SetSelectionT

Pull Buttons in the side panel do not update properly when teeming checkbox is being toggled.

We typically pull additional bats flying in the red zone from the blue marker, but the bats are missing (in case they do not count as "patrols").

It shows up on the list of addons on and i can disable/activate but it doesn't show up on interface/addons on the menu in-game list, nor map and shortcut commands doesn't work

https://i.imgur.com/tPH7pXf.png
I've tried reinstalling it several times without making it work

Like the title says.

Also to follow up so I don't clog the issues. I think you're missing a Rift Warden in Seat near the 2nd boss.

-edit. I revisited the Rift Warden spawn thing later and found that there is more potential spawns that aren't currently mapped in the addon. I don't know if this is intentional, but it does change the pulls depending on spawn count. I was attempting to make a preset for each possible route, which is dependent on the spawn of those rifts.

So far I have these locations as well as some evidence to their existence in m+(in the event you choose to map them):

Spawn by the water

Map Location:

Evidence:

Spawn in the shadow pool on right side

Map Location:

Evidence:

Spawn Near Boss (mentioned in the original comment)

Map Location:

Evidence:

-maybe giving some preset pulls for dungeons,maybe a way of ppl of shareing them like weakauras inside or outside a game
-giving shareing pulls to other like in addons silimar to angry assiments
-would it possialbe to have some sort of arrow in dungeon or some sort of overlay on minimap to fgive ppl directions to go for certain mobs next

Let it switch to red if you are over the count. Maybe fade to a darker red if you go more and mroe over the count