noaa-csl / noaa_bbb_pru_daq_cape Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 4.0 15.28 MB

NOAA_BBB_PRU_DAQ_Cape

Makefile 0.70% C 10.49% Shell 0.22% OpenEdge ABL 0.78% QMake 0.08% C++ 87.72%

noaa_bbb_pru_daq_cape's People

Contributors

Stargazers

Watchers

Forkers

gavinmcmeeking lo-co u-bundke stahta01

noaa_bbb_pru_daq_cape's Issues

MIN and MAX not used

The functions MIN and MAX are not used. These can either be removed or changed to preprocessor definitions like so:

#define MIN(a, b) ((a) < (b) ? (a) : (b))
#define MAX(a, b) ((a) > (b) ? (a) : (b))

Move build script into current Makefile

Current build file is redundant and can simply be moved to the Makefile that currently exists. In fact, I would make several rules out of this - a peak file rule, a pops rule and at least one PRU rule.

Convert comments to Doxygen format

This is a pretty standard format that allows you to generate documentation on the code directly from the code itself. More information on doxygen is here.

Example:

Current code:

//******************************************************************************
//
//  CompressBins
//
//  Compress 16 BINS to 8.  Used on some balloon or aircraft Status outputs.
//
//  gHist 0..5 are 16 bin data
//  gHist 6 is 6+7+8+9
//  gHist 7 is 10+11+12+13+14+15
//
//******************************************************************************

void CompressBins(void)
{
    ...
}

Suggested format:

/**
 * @brief Compress 16 BINS to 8.  Used on some balloon or aircraft Status outputs.
 * 
 * `gHist` 0..5 are 16 bin data
 * `gHist` 6 is 6+7+8+9
 * `gHist` 7 is 10+11+12+13+14+15
 * 
 */
void CompressBins(void)
{
    ...
}

pops_instrument_images

Random structs

There are a lot of structs that contain one member. Examples:

struct gUDP
{
    struct UDP udp[6];
} gUDP;

struct gData
{
    struct Peaks peak[30000];
} gData;

struct gSerial_Ports
{
    struct Serial_Port serial_port[2];
} gSerial_Ports;

Is there a reason that these reside in structs?

Close UDP socket function not needed

This function just wraps the function close.

Unused input parameter in UDP_Read_data

In the function int UDP_Read_Data(int fd, int i);, the input parameter i is never used and can be removed.