noazark / food-junkie Goto Github PK

Note: original issue noazark/battered-oats#12

Ok, so the problem is that cleaning the syntax node tree is actually good. As of noazark/battered-oats@e7574678eb03bab08c238cfc5a5696747861da7d I disabled the cleaning and it adds an 8 second delay (because of the deep traversal) to the view rendering. Cleaning the tree is used all over the place for step and ingredient extraction.

Food Junkie needs a rework anyways but it would be awesome to properly solve this issue.

Note: I stopped cleaning up the tree because it destroys labels.

Note: original issue noazark/battered-oats#3

FoodJunkie::SyntaxNode::Time#to_i fails to convert '1 1/2 hours' to 54000 milliseconds.

Food Junkie uses Chronic to convert natural language time strings to milliseconds. Unfortunately Chronic doesn't support fractions currently. Either, add fraction support to Chronic or convert fractions before parsing time.