Comments (2)
Is this fixed / captured by the PR that was just merged, or is this a separate issue?
Additionally, if this is a separate issue, what impact does it have on the executor?
I agree that the executor waking up for no reason is not desirable, but it does not induce unexpected behaviour and I don't expect the performance impact to be major. Can you give me an indication of the urgency of the fix?
Also, what fix would you suggest. Is there another check besides is_ready()
that can be performed to prevent this behaviour. And if so, what is the performance impact of the check vs. the performance impact of the unnecessary awakes?
from static_executor.
This is a separate issue from the PR created by @mauropasse .
However, that PR already contributes to mitigate the overhead, because it makes sure that no work is performed in these "spurious" awakes.
I agree with you that the impact should no be that much, anyhow, I'm creating some tests for exactly measuring it.
Unfortunately I don't have a solution at the moment, I opened this ticket mainly to make you aware of the issue.
I will investigate more at how the SingleThreadExecutor
uses the memory strategy to get ready executables, because that approach apparently fixes the problem. I will see if it's possible to integrate it in the StaticExecutor
to gain some performance.
from static_executor.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from static_executor.