GithubHelp home page GithubHelp logo

Comments (3)

mauropasse avatar mauropasse commented on July 17, 2024

The problem was that we were not using the executor's guard condition. Since the last commit we only check for node's guard condition triggered to refresh the executable list, but not executor's. I have already a fix with a new implementation with a waitable approach, I'll open the PR soon

from static_executor.

MartinCornelis2 avatar MartinCornelis2 commented on July 17, 2024

Hi, Thanks for notifying me. I think I will have some time tomorrow to run the unit-tests. Would be good to recreate the issue first on my side and then test again with your new PR.

from static_executor.

alsora avatar alsora commented on July 17, 2024

Closing this.
I created real unit-tests from that file, unfortunately I have some issues when GTests are executed in parallel... As soon as I fix them I will open a PR to rclcpp

from static_executor.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.