GithubHelp home page GithubHelp logo

Comments (5)

sampsongao avatar sampsongao commented on May 12, 2024

For the third point, I think v8's string API takes int as parameters. So we should keep it consistent to v8 api.

from abi-stable-node.

digitalinfinity avatar digitalinfinity commented on May 12, 2024

A quick skim through node_api_types.h and node_api.h indicate that most of these have been addressed with the exception of the first item. @mhdawson @jasongin can one of you sanity check for me please? I assume we'll want to do the first item soon?

from abi-stable-node.

jasongin avatar jasongin commented on May 12, 2024

The first suggestion does not break the ABI, though it could break source code, if someone is implicitly converting one of those typedefs to void. So if we're going to do it, we should do it soon. It's just a minor thing though, so not critical in my opinion.

from abi-stable-node.

jasongin avatar jasongin commented on May 12, 2024

And yes, items 2, 3, and 4 were resolved long ago.

from abi-stable-node.

mhdawson avatar mhdawson commented on May 12, 2024

Looks like these have all been addressed long ago, closing. Please let us know if that was not the right thing to do.

from abi-stable-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.