nodejs / caritat Goto Github PK

Adding a "url" and/or "homepage" entry in the package.json would result in the version published to npm linking to this repository. (I had to do a little bit of guessing to find it!)

The generated json contains only the following fields:

• encryptedSecret
• data

The author field is missing.

I'm not sure this project is the right place to open the issue. Sorry if the message is generated elsewhere.
I'm taking this message as a reference: nodejs/TSC#1225 (comment)

1. When I voted, I didn't think that a readable version of the voting options was available in the first commit, so I thought that I had to start the process to know what the options were. My suggestion would be to add the list of options to the pull request description, before listing the different voting methods.
2. That may be more difficult to handle here, but I think it's important to make sure that all people how are allowed to vote are aware that a vote started. In the case of the Node.js TSC, I would add a ping of the @nodejs/tsc GitHub team to the pull request description.

After filling https://stduhpf.github.io/caritat/#https://github.com/nodejs/TSC/pull/1158 with all my details, when I click on Encrypt ballot, an error message shows up at the bottom of the page:

An error occured: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.

I noticed this only after I committed the faulty vote I reported in #3, not sure if it happens otherwise.

System info:

$ uname -a
Darwin Darshans-MacBook-Pro.local 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:54 PST 2021; root:xnu-8019.61.5~1/RELEASE_X86_64 x86_64
$ openssl version
OpenSSL 3.0.1 14 Dec 2021 (Library: OpenSSL 3.0.1 14 Dec 2021)

Logs:

$ sh ./voteUsingGit.sh \
  RaisinTen \
  [email protected]:nodejs/TSC.git \
  vote-primordials-error-path \
  votes/primordials-error-path
Cloning into '.'...
remote: Enumerating objects: 304, done.
remote: Counting objects: 100% (304/304), done.
remote: Compressing objects: 100% (295/295), done.
remote: Total 304 (delta 12), reused 162 (delta 7), pack-reused 0
Receiving objects: 100% (304/304), 2.23 MiB | 2.40 MiB/s, done.
Resolving deltas: 100% (12/12), done.
./voteUsingGit.sh: line 20: /var/folders/1s/mr6_sxdx0_59tj0xq5qzt_z00000gn/T/tmp.u5ibUVMK/votes/primordials-error-path/ballot.yml: Permission denied
./voteUsingGit.sh: line 23: /Users/raisinten/Desktop/temp/project/sh/encryptBallot.sh: No such file or directory
[vote-primordials-error-path 1466e68] vote from RaisinTen
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 votes/primordials-error-path/RaisinTen.json
Enumerating objects: 8, done.
Counting objects: 100% (8/8), done.
Delta compression using up to 8 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (5/5), 1.03 KiB | 1.03 MiB/s, done.
Total 5 (delta 3), reused 0 (delta 0)
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
To github.com:nodejs/TSC.git
   a619c98..1466e68  HEAD -> vote-primordials-error-path

This ends up committing and pushing an empty file.

Workaround:

I believe running with sudo should be a temporary fix for now.

In the markdown preview, the winning candidates should be displayed as a markdown list if there are more than one of them. A comma separated list as it is today creates problem if the candidate themselves contain commas, or if they are quite long.

Expected results

**Winning candidate(s)**:

 - Option Z
 - Option X

Actual results

**Winning candidate(s)**: Option Z, Option X