Comments (9)
Wow, that's a lot! Great to see so many new contributors ❤️ . Thanks so much for organizing @gireeshpunathil. I was able to land a bunch of them, waiting for the CI on a few more. Thanks to @jasnell, @tniessen, @cjihrig, @danbev, and @vsemozhetbyt for all the reviews 🙏 .
from code-and-learn.
That's great. Thanks so much! I'll try to do a review on Saturday of the PRs.
from code-and-learn.
@thefourtheye if you happen to have time :)
from code-and-learn.
@Trott - Acknowledged. For the lib
, I have cautioned people on the significance and sensitivity of the module and recommended to pick up only simple, and obvious changes, if at all. I hope that has been abided by.
@fhinkel - thank you very much for the review, and especially the kind messages you left on the landing, that means a lot to the new co ers I am sure!
Thank you all the mentors who reviewed with absolute receptiveness, approachability and sympathy - I am sure this has cast the best PR experience possible to the contributors which they will cherish for a long time and drive them to come back.
Closing this issue as its purpose is met, having almost all the PRs in the codebase.
from code-and-learn.
Thanks for running the Code and Learn @gireeshpunathil. I have time for some reviews. Is there a particular label I can search for?
from code-and-learn.
thanks @fhinkel . code&learn
is the label. PRs #16910 - #16933 , almost continuous .
from code-and-learn.
nodejs/node#16910 - nodejs/node#16933
from code-and-learn.
There seem to be a lot of changes in lib
in these issues. I tend to avoid those for Code + Learn because it can mean people end up making changes that need to be benchmarked, and that can be a bit more than people are prepared to undertake at first. Hopefully none of these are in hot paths and/or the perf differences of these types of changes are known to be so insignificant that it doesn't matter.
from code-and-learn.
Overall, looks really good. Nice job, @gireeshpunathil! Some smaller Code + Learn events have not gone so well. I think @benjamingr has run some good ones too.
from code-and-learn.
Related Issues (20)
- Code & Learn Saint Petersburg 2020 HOT 2
- Next events? HOT 10
- Mentors for Code-and-Learn @ NodeConf EU (Nov 5) HOT 8
- Scope of Code + Learn for JS Interactive 2018 HOT 8
- Code + Learn Copy for the JS Interactive Website HOT 7
- Mentors for Code + Learn @ Node+JS Interactive 2018 HOT 36
- COSCon'18 (China Open Source Conf) wants to hold a Code + Learn Workshop HOT 55
- Common questions at C&L events HOT 7
- Mentors for Code + Learn @ NodeConf Colombia 2019 HOT 14
- Bangalore, November 17th HOT 16
- Example coverage task HOT 1
- Mentors for Code-and-Learn @ Seattle (Dec 18) HOT 7
- JSConf Budapest 2019 would like to hold a Code & Learn Workshop HOT 11
- Code And Learn at NodeFest 2018 HOT 4
- CFP: Code + Learn @ JSConf.Asia (Singapore) 2019-06-[14|15|16] HOT 5
- Code And Learn At Beijing April 28th HOT 7
- Code & Learn Saint Petersburg 2019 HOT 9
- Bangalore, May 25th HOT 4
- Node.js Code + Learn at COSCon'19 (China Open Source Conf) HOT 14
- Code & Learn Moscow 2019 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from code-and-learn.