nodejs / commit-queue Goto Github PK

Off the top of my head:

• Something that can land the PR automatically: git-node land
• A protocol for squashing commits
  • Option 1: Use the --autosquash feature of git and ask everybody to use --fixup or --squash when they create commits that should be squashed
  • Option 2: Just squash everything in the same PR. AFAIK the commit queue of V8 does this. I like it because it's simple and we should enforce that commits that can be submitted as separate PRs must be, then it'll be easier to backport PRs since we no longer mix semver-major changes in refactor/clean-ups. And this makes it easier to review PRs, revert commits, etc.
• Master/worker server applications to run the landing tool -> the queue. I think it's pretty obvious that we will implement them in Node.js?
• A bot or a Jenkins CI job for triggering the landing process
• Modification to git-node to store more metadata tracking PRs and queued jobs

For reference:

https://dev.chromium.org/developers/testing/commit-queue
https://dev.chromium.org/developers/testing/commit-queue/design

Added:

• Estimate the workload by looking into the velocity of the project
• Figure out how to isolate the master/worker and orchestrate and where they should be deployed