nogarcia / xkcdn Goto Github PK

Everyone loves mousing over the image and getting those little extra kicks of humor.

Difficult way: get every single comic title and return the one that matches.
I'd be grateful if anyone could think of a better way.

I realize not everyone likes to download webcomics, so I'll probably add in @itsron717's approach.

Build tests are good for making sure your code works. Plus, you get that nice little checkmark.

I'm not sure whether it's a good practice or not, but it sure makes the code look way better.

In the following form, please.

try:
	# do what you do
except RandomError:
	# Report error

Good opensource practice: label your code.

Committing to master isn't really a good practice, but at the same time, there's not really not very much code to be unstable. It either works or not works. You get system exclusive bugs in larger systems.

Describe the bug
When downloading an animated comic, the script downloads the bytes and names them as a PNG. The file fails to load in an image editor. 1264 is a still image in ImageMagick. The file is verifiably a GIF when viewed in a hex editor.

To Reproduce
Steps to reproduce the behavior:
1.

$ xkcdn --num 1264 # any animated comic

2. Open the file in EOG or any other image viewer.

Expected behavior
The image is recognized as a GIF and is aptly named.

Desktop (please complete the following information):

• OS: Ubuntu 18.04.1 LTS
• Version: latest

I don't want this to be too much like the original terminal XKCD, but I want this feature.

Get num of latest comic and pick a random number in between 1 and that number.

The code is a mess currently. It'd be helpful to have a logic rewrite and a separation of all the processes.

Usage: xkcdn --num 614
Result:

Can't leave out those guys without desktop environments. I'd like to use @purrleterian's 2ASCIIpy, but it is not in a package manager.

While the name is punny, it's annoying to type repeatedly.

XKCD can get pretty meta. I'd like to get an explanation.
This would require some web-scraping, which can get kludgy really quickly.