nosefish / fishysigns Goto Github PK

Usually, output levers levers should be updated not earlier than 2 ticks after the hook came in.

Removal of unloaded signs should be handled by a ChunkUnloadWatcher, to which FishySign subscribes and upon receiving the respective activator removes calls the remove method. There could be other removal methods, e.g. timeouts for self-destroying signs. Would free the ActivationManager of the burden of tracking locations of signs, too, resulting in a whole new level of awesomeness.

many classes and methods have no or incomplete javadocs

The FishySignClassLoader only supports loading from jars. Add support for runtime registration of classes from plugins.

CanaryRecode has recently added a persistent "owner" field to signs. This will make some interesting features possible.

mco's /ic + more, built-in

this causes FishySigns not to be removed from the ActivationManager when they are not broken directly, but the block they are attached to is. Memory leak + very strange behaviour bugs.

When a chunk is unloaded, sometimes the Activatables are not removed. They are then registered a second time when the chunk is loaded again, consuming more and more memory and CPU time.

probably also /disableplugin - /enableplugin, but I haven't tested those yet.

Must be doing things from the wrong thread somewhere.
MinecraftServer.t(MinecraftServer.java:451) is a call to the ServerTickHook.

2013-09-02 20:32:35 [SEVERE] Encountered an unexpected exception ConcurrentModificationException
java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:819)
    at java.util.ArrayList$Itr.next(ArrayList.java:791)
    at net.canarymod.hook.HookExecutor.callHook(HookExecutor.java:107)
    at net.canarymod.hook.Hook.call(Hook.java:37)
    at net.minecraft.server.MinecraftServer.t(MinecraftServer.java:451)
    at net.minecraft.server.DedicatedServer.t(DedicatedServer.java:198)
    at net.minecraft.server.MinecraftServer.s(MinecraftServer.java:415)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:351)
    at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:13)

Could be done with particle effects. But first we need ICs that would use this.

with the enhancements of #6, DirectInputBox could be Activatable. Same with the rest: make an AntennaInputBox, RightClickInputBox, as separate activatables. Much cleaner design. Would also mitigate the super() chaos in initialize() and remove() somewhat.

Thanks to getLoadedChunks having been implemented it is now possible to do this, so I should.