GithubHelp home page GithubHelp logo

nosto / nosto-magento2 Goto Github PK

View Code? Open in Web Editor NEW
27.0 27.0 26.0 5.2 MB

Home Page: https://marketplace.magento.com/nosto-module-nostotagging.html

License: Open Software License 3.0

PHP 94.44% JavaScript 2.01% HTML 3.47% Shell 0.09%
ecommerce magento magento2 magento2-module personalization

nosto-magento2's People

Contributors

barbanet avatar chapagain avatar dairbuirabass avatar danslo avatar davefarthing avatar dependabot[bot] avatar dupadhyay3 avatar dvynograd avatar hostep avatar jluostar avatar liangde-chen avatar loxzibit avatar mridang avatar nilroy avatar olsi-qose avatar phonglynosto avatar piotrkwiecinski avatar supercid avatar tzvicons avatar vmalyk avatar vmlintu-nosto avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

nosto-magento2's Issues

Huge products in iPhone with default Nosto CSS

Problem

In iPhone responsive view and using Nosto's default template/CSS on recommendations, slots shows 1 product / row that takes half of the screen size, while the regular products shows as 2 / row.

See: http://www.vaimo.com/snaps/pablo.ivulic/nosto-m2-category-default-preview.png

Expected Result

Show smaller products, the same size (or smaller) than the regular products. At least 2 products / row, otherwise the user will have to scroll a lot.

Compare with iPad view: http://www.vaimo.com/snaps/pablo.ivulic/nosto-m2-ipad-responsive-ok.png

How to recreate

  1. Create a new Nosto account without modifying any slots settings/templates/CSS.
  2. Preview the frontend, i.e. category or product page (the same goes for all other views)

Add support for Yotpo's ratings and reviews

Merchants should be able to use ratings and reviews from Yotpo if needed. There would need to be a selector in the advanced Nosto configuration that allows merchants to switch between Magento's own rating and reviews and Yotpo's rating and reviews.

No multi site support?

Problem

I'm able to connect Magento with Nosto for 1 store, which results in creating a new account in Nosto. But I can't create new accounts for my other stores.

nosto-m2-no-multi-site-support

Expected Result

If I switch scope to a store that is not yet connected with Nosto, I expect to see the installation page: http://www.vaimo.com/snaps/pablo.ivulic/nosto-m2-init-welcome-page.png

How To Recreate

  1. Connect the default store view with Nosto.
  2. Setup new multi-sites.
  3. Try and connect them to Nosto as well as separate Nosto accounts.

Error in checkout when module is enabled but not configured/linked

Added Nosto module to the composer.json, composer update, composer install, magento module:enable, magento setup:upgrade, magento cache:clean following guide in Wiki.
Site is not linked from the admin yet, waiting for credentials.
Testing checkout, product in cart, checkout loads ok, when making the order (Place Order button) Order Save observer throws an exception.

<br /><b>Fatal error</b>:  Uncaught TypeError: Argument 1 passed to NostoServiceOrder::__construct() 
must be an instance of NostoAccountMetaInterface, null given, called in 
/var/www/vendor/nosto/module-nostotagging/Observer/Order/Save.php on line 135 and defined in 
/var/www/vendor/nosto/php-sdk/src/Service/Order.php:59
Stack trace:
#0 /var/www/vendor/nosto/module-nostotagging/Observer/Order/Save.php(135): NostoServiceOrder-&gt;__construct(NULL)
#1 /var/www/vendor/magento/framework/Event/Invoker/InvokerDefault.php(73): Nosto\Tagging\Observer\Order\Save-&gt;execute(Object(Magento\Framework\Event\Observer))
#2 /var/www/vendor/magento/framework/Event/Invoker/InvokerDefault.php(61): Magento\Framework\Event\Invoker\InvokerDefault-&gt;_callObserverMethod(Object(Nosto\Tagging\Observer\Order\Save), Object(Magento\Framework\Event\Observer))
#3 in <b>/var/www/vendor/nosto/php-sdk/src/Service/Order.php</b> on line <b>59</b><br />{"messages":{"error":[{"code":500,"message":"Fatal Error: 'Uncaught TypeError: Argument 1 passed to NostoServiceOrder::__construct() must be an instance of NostoAccountMetaInterface, null given, called in \/var\/www\/vendor\/nosto\/module-nostotagging\/Observer\/Order\/Save.php on line 135 and defined in \/var\/www\/vendor\/nosto\/php-sdk\/src\/Service\/Order.php:59

Add support for exchange-rates based multi-currency

Multi-currency could be implemented to Magento2. In order to accomplish this, a few things need to be done.

  • Add a cron job to periodically update the exchange-rates
  • Add the active-variation tagging to all pages
  • Update the product tagging to show prices in the base currency
  • Add an observer to update the currency formats when the admin logs in

Add support for handling the qualification UI

The current version of the extension shows the qualification UI but discards all the parameters. Now with the extension listed on Marketplace, it is necessary to add the qualification to the signup flow in Magento.

Add to cart button not working

Hi

In the default template "magento-default" I can enable the add to cart button, it shows up fine but it's onclick is not working.

It is calling Nosto.addProductToCart('[ID]', this); return false;, but Nosto is undefined.

I'm running Magento 2.1.2, Nosto module 1.1.0

Broken support button

Problem

Nothing happens when clicking the support button.

nosto-m2-broken-support-button

Expected Result

Something should happen, maybe https://support.nosto.com/ should be open in a new tab?

How to recreate

  1. Navigate to Nosto in Magento Admin.
  2. Switch to the Recommendations tab.
  3. Scroll down and click the Support button.

Downgrade SDK

This would probably make sense when SDK 3.0.0 is out

Call to a member function getTypeInstance() on null in Helper\Item.php

Environment

  • Windows 10
  • Apache 2.4.17
  • MySQL 5.0.11-dev
  • PHP 5.6.15
  • Magento 2.1.6
  • Nosto_Tagging 1.2.0

Steps to reproduce

  1. Add custom datetime column exported_at to sales_order table
  2. Load an Magento\Sales\Model\Order
  3. Call $order->setExportedAt('2017-04-25 17:49:19')
  4. Call Magento\Sales\Model\OrderRepository->save($order)

Expected result

  • Order should save

Actual result

Fatal error: Call to a member function getTypeInstance() on null in vendor\nosto\module-nostotagging\Helper\Item.php on line 48

Cause

  • A Magento product can be deleted from catalog while old order items remain
  • Nosto\Tagging\Helper\Item doesn't check whether a product exists before calling getTypeInstance()

Compilation errors in version 1.1.0

Hello,

In the latest version 1.1.0 we receive a lots of errors during bin/magento setup:di:compile, here is one sample output:

	Nosto\Tagging\Helper\Account
		Incorrect dependency in class Nosto\Tagging\Helper\Account in /var/www/magento/vendor/nosto/module-nostotagging/Helper/Account.php
\Magento\Framework\Module\Manager already exists in context object
Total Errors Count: 1

They are relatively easy to fix, however they break automatic deploys with production mode.
Magento version is 2.1.3 if is required to know.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.