notegio / massive Goto Github PK

It should be possible to fill an order by piping it into massive.

I am running docker-compose-testrpc.yml and trying to push one order through massive. I am getting this error

$massive 0x csv --input=sample.csv | massive 0x expiration --duration 864000  |massive 0x getFees --maker-share .5 --target http://127.0.0.1:8081/ | massive 0x setExchange --testrpc | massive 0x setSalt |massive 0x sign --replace-on-mismatch privkey.0.asc | massive 0x setAllowance --unlimited http://localhost:18545 privkey.0.asc 
2018/08/11 03:56:10 Error getting fee token address for exhange 0x307834386261636239323636613537306435323130363365663564643936653631363836646265373838
2018/08/11 03:56:10 Error getting fee token for exchange 0x48bacb9266a570d521063ef5dd96e61686dbe788: VM Exception while processing transaction: revert

Looks like something wrong with the contracts installed in testrpc.
I am running Open relay with 0xv2-support and massive with support/0xv1 branches.

It should be possible to use a standard relayer API instance as a massive source.

When there are multiple allowances to be set, the nonce value doesn't seem to be incrementing properly, and the allowance set subcommand is giving the error:

2018/07/10 13:32:42 Error getting / setting allowance the tx doesn't have the correct nonce. account has nonce of: 23 tx has nonce of: 22

Whatever the nonce lookup mechanism is apparently isn't getting updated promptly. I'm not sure whether it gets updated blocks get confirmed, or once a block is seen in the mempool, but it's not accounting for multiple transactions sent from the same process.

As a workaround, running it a few times seems to work, but that's annoying and it's obviously a bug. We should figure out what the nonce resolution mechanism is, and make sure it's getting updated when multiple transactions come from within the process.

Right now signing requires a public key stored in plaintext. This obviously isn't the best from a security perspective. RPC servers like Parity and Geth support signing messages, so we should have an option to delegate signing of messages to those tools.