notenoughupdates / notenoughupdates-repo

This repository is used in order to store the various JSON files used for the Minecraft mod NotEnoughUpdates.

NotEnoughUpdates-REPO

This repository is used in order to store the various JSON files used for the Minecraft mod NotEnoughUpdates.

How to contribute

In order to contribute to the item repo you should enable the item editor tools by editing your config, in your configNew.json (.minecraft\config\notenoughupdates\configNew.json) ensure the following values are set:

"repositoryEditing": true,
"dev": true,

I would also highly recommend disabling auto update if you are in the middle of making changes otherwise they will be overwritten.

"autoupdate_new": false,

Once you have these options enabled you can edit and add items in-game using the following keybinds:

• k - Opens the item editor.
  • TIP: typing 2 & converts into §
• o - While in an items recipe menu, add the recipe.
• y - Opens a pane on the left side of your inventory.
• left ctrl - Hold to show the NBT data of an item.
  • left ctrl+h - copies the nbt data to your clipboard.
• b - While viewing the essence guide of an item, add the essence to the essencecost.json.

Once you have made the changes you would like you can find the files located in .minecraft\config\notenoughupdates\repo.

If you need further help on how to contribute feel free to join the discord.

notenoughupdates-repo's Issues

misspelled wardrobe

NotEnoughUpdates-REPO/constants/disable.json

Line 5 in 8e27908

"enableNewWardrob" : false

typo in "Goblin Holdout"

not sure where this is. code search on both this repo and the other one turns up nothing on "Golbin"

Bane of Arthropods VII book in item list ignore neuec

When you search for the book Bane of Arthropods VII, it always appear in default blue color
But the neuec is applied when looking at the Max Enchanted Book & on items, so i suppose it's only a repo issue

Suggestion: Wiki Pages

Suggestion: Change the mod to use the official wiki pages instead of the unofficial wiki

`Champion` is missing from `constansts/enchants.json`

Better Mayors Missing Items/Stats

• Museum Mining Equipment
• https://cdn.discordapp.com/attachments/720602273461567509/1257698080401395772/1719928919000_skyblock-updated-items.png?ex=66855a1d&is=6684089d&hm=7f91c80f3460813a3cf9c34e000c7023bf5513eed93d016c35afe42663aa6fa8&
• https://cdn.discordapp.com/attachments/720602273461567509/1257698068774518824/1719928919000_skyblock-added-items.png?ex=66855a1a&is=6684089a&hm=154bee4bd59d901ad04e82b55389559d8339a4c47ccd1f22d77b48e77df863fe&
• Shen's Auction Perm Item
• Gleaming Crystal Reforge Stone Stats
• Party Gift in Winter Sack -> sacks file
• sacks file -> Events Sack
• Diaz Lore
• Cole Lore
• Foxy Extra Event and Sweet Benevolence Lore
• Marina Lore

ender gauntlet lore says epic cloak

ender gauntlet lore says epic cloak instead of epic gloves (link)

Outdated Reaper Pepper description

NEU:

Hypixel:

HotM Level Requirement for applicable forge recipes

It would be really cool if you could add the HotM level requirement for all forge recipes that have a requirement (like this one).

This might be kind of weird though as some forge recipes require specific collections levels instead of or in combination with HotM level... Also things like Mole pet require fossils...

Gemstone inconsistancies and non existent items?

This doesn't exist (even though I know it did at one point, that was over a year ago)

Tf is this thing?

The 'Jasper Crystal' should be in the category with the other crystals
The 5 Opal gemstone types should be grouped together like the other gemstones
Although this is kinda neat, why did the pristine enchant come up when I searched 'gemstone'? Nowhere in the lore is the word 'gemstone'

[Suggestion] Change "dungeon_item_level" to "upgrade_level"

Should "dungeon_item_level" in the NBT data of all dungeon items be changed to "upgrade_level" to match Hypixel's new system?

Issues with recipe item non-integer counts

Hi there!

NEU looks to this repository to load various items and recipes. When launching the mod, it looks like some items contain non-integer counts for items within recipes. This causes NumberFormatExceptions (which are ultimately swallowed to prevent crashing). See below for an example:

[io.github.moulberry.notenoughupdates.NEUManager:loadItem:361]: internalName is : UMBER_PLATE
java.lang.NumberFormatException: For input string: "4.0"
  at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
  at java.lang.Integer.parseInt(Integer.java:580)
  at java.lang.Integer.parseInt(Integer.java:615)
  at io.github.moulberry.notenoughupdates.recipes.Ingredient.<init>(Ingredient.java:45)
  at io.github.moulberry.notenoughupdates.recipes.ForgeRecipe.parseForgeRecipe(ForgeRecipe.java:221)
  at io.github.moulberry.notenoughupdates.recipes.RecipeType.createRecipe(RecipeType.java:65)
  at io.github.moulberry.notenoughupdates.recipes.NeuRecipe.parseRecipe(NeuRecipe.java:79)
  at io.github.moulberry.notenoughupdates.NEUManager.loadItem(NEUManager.java:313)
...

The Ingredient constructor fails to handle a count with a decimal part (even if this part is .0`):

// Ingredient::init(NEUManager, String)
...
if (parts.length == 2) {
  count = Integer.parseInt(parts[1]); // This fails if the count is 'integer-like' but with decimal parts (eg. '4.0').
}
...

UMBER_PLATE looks to contain such values:

"inputs": [
  "REFINED_UMBER:4.0",
  "GLACITE_AMALGAMATION:1.0"
],

I would suggest that the fix for this bug would be to update the item recipes to remove the decimal part.

Enderman slayer is missing

The slayer_req is missing for items from the enderman slayer.
Should it be EMAN_X or ENDERMAN_X (I intend to make a PR later today)

Missing Hub NPC's

Following Hub NPC's are missing in the REPO:

Billy Joe
Bobby Joe
Curator
Gladiator
Hootie
Hub Selector
Jim Bob
Minikloon
Mort
Salesman
Security Sloth
The Handler

I don't know if they were just forgotten or if this is on purpose how it is, so lmk :).

[Suggestion] Do admin-only items need to be added to the repo?

For example, https://hypixel-skyblock.fandom.com/wiki/Anubis, does this need to be added to the repo? all the nbt data is avaliable.

Incorrect Textures for KARATE_FISH

All the KARATE_FISH_ use the KARATE_FISH_SILVER texture. Not sure why this is, just wanted to let you know.

[Suggestion] Suggestion to add these recipes

While doing a simple scan I stumbled upon few items which were missing or could be better for the dataset

• Missing Counter Strike III and IV
• Rename ENCHANTED_CARROT_STICK to ENCHANTED_CARROT_ON_A_STICK to match the ID more

These were my only discovery so far =)

New weaponsmith items?

New weaponsmith items

Originally posted by @Strebbypatty in #547

[Missing] SULPHER_SKITTER_DIAMOND

Sorry to be a bother, but we are still missing the item SULPHER_SKITTER_DIAMOND.

Birch Park twice did you mean Lonely Island?

https://github.com/NotEnoughUpdates/NotEnoughUpdates-REPO/blame/516136d7de42a0bea990f784cf7e05eaae5523e1/constants/zones.json#L80

[Suggestion] Furnace recipes

Is there any possibility of furnace recipes being added? I don't know if there are any custom furnace recipes on Hypixel, but Cactus Green not having a crafting recipe of Cactus in furnace, which has a cost of 0.9 makes the Windows Forms app I'm designing kind of break when an Enchanted Cactus costs -25,600 to buy, but sells for 25,028.77.

Weird NETHER_BRICK and NETHER_BRICK_ITEM items

There are two items for Nether Bricks which both look like the nether brick block.

They have completely empty recipes, and pressing r on a nether brick (item) that you got by smelting netherrack (the ingot looking one) leads you to a recipe for one of the two.

[Suggestion] Item Info Attributes

I was wondering if it's possible to add attribute information such as if an item is auctionable, tradable, sellable, etc?

Wooden Pickaxe and some other recipers not here

Hiya

Is there a reason that some items aren't in this list?