notiz-dev / scully-plugins Goto Github PK

Improve RSS plugin by changing the plugin type from render to the new routeDiscoveryDone plugin type. This should speed up build time for this plugin. Right now RSS plugin is executed for each route.

I have the filename set to blog-feed.{xml,json,atom} but it's being output as feed.{xml,json,atom}

Plugin type render is deprecated in [email protected]. Use postProcessByHtml instead.

For some reason, only some of the routes are being used for my site. There should be around 70, but only two are being used and have entries in the rss feed.

Scully uses format of front-matter, but rss plugin uses some properties that doesn't exist in standard Front Matter of Scully v2, for example such as publishedAt, updatedAt, authors

what would is the approach to followed?

Modify the Front Matter in my Scully content or Do you have some plan to resolve this?

Adding lazyImages to postRenderers of a route and adding the following images to the content:

![Unsplash](https://source.unsplash.com/random)
![Random](https://picsum.photos/500)

Those images are not loaded.

Thank you for creating this plugin. Although unfortunately when I tried it out it didn't work for me. src were not replaced with data-src and all the images were loaded instantly. But it did produce a lot of layout shifting due to image size changing. All I did was just included the plugin in defaultPostrenderes and that's all. But even if the sizing issue is gone, I checked the source code and it's lacking handling of srcset which I have quite a lot on my site.
I could help addressing these issues, but I need some guidance.

In order to use the feed to automate sending emails, I need the newest posts first, but this only allows for latest posts. I'm thinking an option in the config like:

newestPostsFirst: true | false

🐞 Bug report

Description

The plugin does not automatically ignore image file routes and will instead error out and print an error message to the console during Scully build. The plugin handler is skipped so this does not result in build failure, but the generated error messages are noise in the console.

The ideal behaviour here would be to just skip processing image file routes.

🔬 Minimal Reproduction

Any Scully project using the @notiz/scully-plugin-lazy-images plugin in defaultPostRenderers of the Scully config with a fileHandler plugin registered e.g. registerPlugin('fileHandler', 'png', imageFilePlugin);.

💻Your Environment

Angular Version:

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 11.0.5
Node: 14.8.0
OS: darwin x64

Angular: 11.0.5
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.5
@angular-devkit/build-angular   0.1100.5
@angular-devkit/core            11.0.5
@angular-devkit/schematics      11.0.5
@angular/cdk                    11.0.3
@angular/material               11.0.3
@schematics/angular             11.0.5
@schematics/update              0.1100.5
rxjs                            6.6.3
typescript                      4.0.5

Scully Version:

"@scullyio/init": "^1.0.1"
"@scullyio/ng-lib": "^1.0.0"
"@scullyio/scully": "^1.0.0"
"@notiz/scully-plugin-lazy-images": "^0.3.0"

🔥 Exception or Error

Error during content generation with plugin "lazyImages" for ./projects/website/blog-posts/images/banner.jpg. This hander is skipped.

Unpublished posts shouldn't be placed in the RSS feed. This allows for posts to be scheduled in the future, or for them to be removed from the RSS feed.

The logged output when the files are created have two log messages for feed.atom and one for feed.xml. One of the feed.atom should be feed.json.