npm / action-deploy

Action to manage GitHub deployments

We've moved!

Hi! This repository is no longer being used and has been archived for historical purposes.

• 🛠 CLI Source Code & Pull Requests now live at github.com/npm/cli

• 🐞 Bugs: Reports of bugs can be filed against our new repo github.com/npm/cli.

• ⭐️ Feature Requests: Add your request or discuss the project w/ the community at github.com/npm/rfcs/discussions

• 📃 RFCs: Create a more formal proposal/idea via our github.com/npm/rfcs

• 🗂 Documentation: References docs & how-tos can be found at docs.npmjs.com

• 📫 Support: You can find links to all our various help channels via npm.community or file an issue at npmjs.com/support

For more information on the move, see our blog post about this transition, and this thread with additional questions. We look forward to seeing you in our new spaces!

action-deploy's Issues

[BUG] Deprecated APIs

What / Why

Just trying this for the first time and saw these in my logs when using v2
Warning: The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

When

When running for the first time, no special configuration

Where

Private organization repository

This branch has not been deployed when running on `pull_request`

I am running into the deployments not showing up when trying to run on a pull_request

action-deploy/src/create.ts

Line 75 in 499b502

ref: context.ref,

The logs are coming up with a ref of refs/pull/1654/merge which I think is the issue.

  "sha": "43fcda52ad5bdc6c559ec6f534bda3af53e53c6c",
  "ref": "refs/pull/1654/merge",
  "payload": "{\"actor\":\"wSedlacek\",\"main_sha\":\"2ff68a6de2b4cb6cfb5c118fd19ee5d654c5924a\"}",
  "transient_environment": true,
  "production_environment": false,
  "performed_via_github_app": null

From reading the code there doesn't appear to be a way to configure this ref, however I believe I want it to be the github.head_ref || github.ref for them to show up correctly. This is just a hunch though.