nrc / deglobber Goto Github PK

Use the code for dealing with opts in driver, rather than trying to emulate it.

The deglobber should take an argument which filters by filename. E.g., deglob -f foo.rs would only modify files called foo.rs.

I think we have to require that the user supply a sysroot, I don't think there is any better way to get one.

It would be easier, and I think more DRY, to first run the compiler with --save-analysis, then use that output as input to the deglobber, rather than doing a partial compile as part of deglobbing. Otherwise being able to run over rustc or other projects with complicated build processes is going to be not-fun.

To make this usable, we'll probably want to implement --save-analysis for Cargo, if that can't be easily done already.

The downside of this is that it makes the deglobbing process more complicated than just running a single command. Also the deglobber is a nice proof of concept for a tool using librusc as a library.

Currently we supply a file name, seems unnecessary.

Sensible options seem to be:

• one big list of imports: use foo::{a, b, c, d, ...};
• one import per line:

use foo::a;
use foo::b;
...

• the maximum number of imports per line whilst keeping the line length under some user supplied n, defaulting to 80:

use foo::{a, b, c};
use foo::{d, e};