nunit / nunit-distribution Goto Github PK

The zip is ending up with multiple .addins files. There is a static nunit.engine.addins file in this repo, which should be copied in, and there should be no others.

Additional .addin files are being copied in from the NUnit.ConsoleRunner and NUnit V2 Framework Driver packages. The line in the build script which copies all contents of a NuGet file into the zip directory should exclude any .addin files it finds.

With the 3.5 release, the changes.txt file wasn't updated at first, and the question came up as to whether that was even a useful file to have.

I suggest we scrap it, it's too error prone. If we think there's a use for having a text contents, we could autogenerate something, showing the package versions included?

Alternatively, if we want to keep it, we should automate it.

The wix files are currently split between two directories common and nunit - as a legacy artifact of when there were two separate msi installers during the beta.

This makes no sense any more, and the files should be split between the new resources and nunit directories.

The Appveyor CI has now been moved to the main account - @rprouse or @CharliePoole - can one of you update where the webhook points to for this repo?

The new link is: https://ci.appveyor.com/api/github/webhook?id=1r1f89j2mw6hahb6

It's just that which needs updating as far as I can tell, the appveyor badge in the readme is relevant to the repo's github location instead.

Discovered during 3.6 release, something introduced with #12 and the Extended NuGet cake plug in means this is now dependent on nuget.exe being on the path. Needs further investigation.

@ipavlu commented on Tue Jun 13 2017

Hi, please drop damned prerequisites testing from MSI package, it does not understand Win10 with built in .Net...

.Net 2.0, 3.5, 4.0 are all present on the machine, just not explicitly, tehre are not even features on win10 that could be enabled as netfx4. It is really incorrect test...

@jnm2 commented on Tue Jun 13 2017

Dunno if this is related, but .Net 2.0 though 3.5 are not present on Win10 until you explicitly install them via 'Turn Windows features on or off.'

@ChrisMaddock commented on Wed Jun 14 2017

I'll move this to the nunit-distribution repo, where the msi is currently built, and comment further there.

Probably need to pin the version of the helpers or update cake to a newer version.

https://ci.appveyor.com/project/CharliePoole/nunit-distribution/build/1.0.169

The Teamcity plug in was removed a few months ago when the future direction of the integration was unclear, however, I believe it was agreed to put it back in to the shared nuget packages and msi.

@CharliePoole - can you confirm that's what needed to happen?

@hiredgunhouse commented on Wed Nov 16 2016

Here https://github.com/nunit/nunit-console/releases/tag/3.5 you can download a package that is called "NUnit Console 3.5" but the main zip and msi files are named NUnit.3.5.0.zip and NUnit.3.5.0.msi which is very confusing if you consider that here https://github.com/nunit/nunit/releases/tag/3.5 you can download the main package called "NUnit 3.5" which gives you the main zip file named "NUnit-3.5.0.zip".
Can you spot the difference?
NUnit.3.5.0.zip vs NUnit-3.5.0.zip
Very confusing after you download the files cause you can tell which one is which.
Wouldn't it be better if the console package was named xxxxx-console or something similar?

@rprouse commented on Wed Nov 16 2016

Agreed, the ZIP files that we create in this repo should be renamed.

@rprouse commented on Wed Nov 16 2016

This is left over from when we split the repositories. It is an easy fix, we just need to update the names in build.cake

@ChrisMaddock commented on Wed Nov 16 2016

Just a note - the zip with the release here is (I think!) built in nunit-distribution, and contains all the extensions too.

Whether that's how it should be or not...not sure!

@ChrisMaddock commented on Thu Nov 24 2016

I wanted to do some tidying up of nunit-distribution before the next release anyway. The zip packages is made in that repo now, so I'm going to move the issue over there. @hiredgunhouse - feel free to subscribe to the new issue. 😄