Comments (7)
This can actually be an error. A temporary can not bind to a non-const reference, therefore the signature of Offscreen.draw
should be: void draw(VkCommandBuffer cmdBuf, const VkExtent2D& size);
Can you please verify that this change fixes it?
from vk_raytracing_tutorial_khr.
This indeed fixes it... there are a couple of more errors related to this.
I would not mind to create a pull request which fixes this, just tell me what you would prefer.
Just keep in mind this also affects the nvpro-core/nvvk library in particular sbtwrapper_vk.hpp/cpp also need to be changed (since this is a different repository im not sure if this could break something anywhere else)
The function defintion in the header/src has to be changed from
std::array<VkStridedDeviceAddressRegionKHR, 4> getRegions();
to
const std::array<VkStridedDeviceAddressRegionKHR, 4> getRegions();
Cheers
from vk_raytracing_tutorial_khr.
Thanks @jruebsam for reporting this. I will also apply the fix for getRegion()
in sbtWrapper
.
We do not develop in Github, therefore it would still be preferable if you list the errors here.
Could you please tell me which compiler you are using?
from vk_raytracing_tutorial_khr.
Sure no problem, this is g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
I also attached some of the linking options maybe it helps
cd /home/jonas/code/nvpro/vk_raytracing_tutorial_KHR/build/ray_tracing_gltf && /usr/bin/c++ -DLINUX -DNVP_SUPPORTS_VULKANSDK -DPROJECT_DOWNLOAD_RELDIRECTORY="../../downloaded_resources/" -DPROJECT_NAME="vk_ray_tracing_gltf_KHR" -DPROJECT_RELDIRECTORY="../../vk_raytracing_tutorial_KHR/ray_tracing_gltf/" -DRESOURCE_DIRECTORY="/home/jonas/code/nvpro/nvpro_core/resources/" -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_XLIB_KHR -DVULKAN_HPP_DISPATCH_LOADER_DYNAMIC=1 -I/home/jonas/code/nvpro/vk_raytracing_tutorial_KHR/build/ray_tracing_gltf -I/home/jonas/code/nvpro/vk_raytracing_tutorial_KHR/ray_tracing_gltf -I/home/jonas/code/nvpro/nvpro_core -I/home/jonas/code/nvpro/nvpro_core/imgui -I/home/jonas/code/nvpro/vk_raytracing_tutorial_KHR/common -I/home/jonas/code/nvpro/nvpro_core/third_party/cgltf -I/home/jonas/code/nvpro/nvpro_core/third_party/glfw/include -I/home/jonas/code/nvpro/nvpro_core/third_party/imgui -I/home/jonas/code/nvpro/nvpro_core/third_party/stb -I/home/jonas/code/nvpro/nvpro_core/third_party/tinygltf -I/home/jonas/code/nvpro/nvpro_core/third_party/tinyobjloader -I/home/jonas/code/nvpro/nvpro_core/third_party/vma/include -I/home/jonas/code/nvpro/nvpro_core/third_party/NVTX/c/include -O3 -DNDEBUG -fpermissive -std=gnu++17 -o CMakeFiles/vk_ray_tracing_gltf_KHR.dir/hello_vulkan.cpp.o -c /home/jonas/code/nvpro/vk_raytracing_tutorial_KHR/ray_tracing_gltf/hello_vulkan.cpp
from vk_raytracing_tutorial_khr.
Also this is the last error I get which is a little bit different:
vk_raytracing_tutorial_KHR/ray_tracing_advanced_compilation/hello_vulkan.cpp:1013:75: error: no matching function for call to ‘nvvk::SBTWrapper::create(VkPipeline_T*&, VkRayTracingPipelineCreateInfoKHR&, )’
1013 | m_sbtWrapper.create(m_rtPipeline, rayPipelineInfo, {pipelineLibraryInfo});
from vk_raytracing_tutorial_khr.
Hi @jruebsam, we have updated this repository as well as nvpro_core. Can you please confirm that the issues are gone?
Thanks
from vk_raytracing_tutorial_khr.
We have tested on Ubuntu and it compiles. Closing.
from vk_raytracing_tutorial_khr.
Related Issues (20)
- Why did the QUADRO P620 support raytrace? HOT 2
- ray_tracing_motionblur: Validation error HOT 2
- ray_tracing_ao crashes when Nsight is used HOT 2
- Fix raytrace.rgen in ray_tracing__advance HOT 1
- Incorrect srcStageMask in vkCmdPipelineBarrier in ray_tracing_ao HOT 2
- Second rmiss shader defined too early in the tutorial HOT 1
- add new simple sample showing usage of Ada SER functionality (via new VK NV SER ext) HOT 1
- add new simple sample showing new Ada OMM functionality (via new VK NV OMM ext) HOT 1
- What does Nb mean? HOT 2
- confusion about Path_tracing cosine distributed Pdf HOT 7
- gl_InstanceId and gl_InstanceCustomIndex HOT 5
- VK_BUFFER_USAGE_STORAGE_BUFFER_BIT for vertices and indices buffer HOT 2
- gl_LaunchSizeEXT corresponds to the image size provided when calling traceRayEXT HOT 2
- Could NOT find VulkanSDK (missing: VULKAN_LIB VULKANSDK_SHADERC_LIB) HOT 3
- Runtime error in creating swapchain on Tesla T4
- The tutorial page is blank HOT 2
- Link is broken HOT 4
- issue on win10 when cmake HOT 2
- Framebuffer becomes invalid (ray_tracing_gltf) HOT 7
- Indirect Scissor readme has broken link HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vk_raytracing_tutorial_khr.