nysamnang / react-native-24h-timepicker

React Native 24 hours format TimePicker for iOS

Hi there 👋

react-native-24h-timepicker's Issues

Color prop buttons or Component Text button

Warning: componentWillReceiveProps has been renamed

Please, update package to eliminate debug warning message:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: TimePicker

Components state is lost if screen rerenders in background

Hi!

My screen is rerendering in the background as there's progressbars etc which are updating. On every update (once per second) my input into the timepicker is lost (has I haven't been able to press "DONE".

Is there a way to att an "onChange" method to the component?

Or how can this be solved?

Thanks,
D

Picker has been removed from React Native. It can now be installed and imported from '@react-native-picker/picker' instead of 'react-native'

Hi! 👋

Picker has been removed from React Native. It can now be installed and imported from '@react-native-picker/picker' instead of 'react-native' ,
After upgrading react native to the latest version it stopped using Picker which is called in the react-native-24h-timepicker package

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-24h-timepicker/src/index.js b/node_modules/react-native-24h-timepicker/src/index.js
index 14e68e6..9e13701 100644
--- a/node_modules/react-native-24h-timepicker/src/index.js
+++ b/node_modules/react-native-24h-timepicker/src/index.js
@@ -1,6 +1,7 @@
 import React, { Component } from "react";
 import PropTypes from "prop-types";
-import { View, TouchableOpacity, Text, Picker } from "react-native";
+import { View, TouchableOpacity, Text } from "react-native";
+import {Picker} from '@react-native-picker/picker';
 import RBSheet from "react-native-raw-bottom-sheet";
 import styles from "./styles";
 

This issue body was partially generated by patch-package.

No period of time like: AM and PM

I'm using this library but I can't use the 12hour maixmumHour because it don't have the period of time. So I stay in 24 hours so that I can determine if it's PM or AM.

I hope you can work on the time period.

Warning: componentWillReceiveProps

Hi,

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

• Move data fetching code or side effects to componentDidUpdate.
• If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
• Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: TimePicker

Setting minutes after setting hour reset both at 0

Everything is in the title. I have copied and pasted the exemple code but still have this issue.
When I only set hour sand hit confirm, it works.
When I only set minutes and hit confirm, it works.
When I set both, it goes back to 0:00 before I can hit the confirm button.

Tested on iPhone 11 Pro Max IOS 14.0

Minimum Hour

A feature request for being able to set the Minimum Hour.

How can have two TimePicker for startTime and endTime?

Hi
If I have two TimePicker and set ref for both of them 'TimePicker', when I change value of second TimePicker, just the value of first one is changed.

Warning RN V0.63

React Native 0.63
Xcode 12.1

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

Animated: useNativeDriverwas not specified. This is a required option and must be explicitly set totrueorfalse``