Arduino language support request about onefetch

[spenserblack]

Thanks for the request! Would you be willing to create your own ASCII art?

Also, FYI 😉

• #1152
• spenserblack/gengo#34

[Sh4rk-Byte]

ascii-art.txt

There's the ASCII art, it's supposed to be this color: #189ba1.

[spenserblack]

(Posting the ASCII art in the comments for easier access)

                                       --+++++++++++++++++++-                                       
                                --+++++++++++++++++++++++++++++++++-                                
                            -+++++++++++++++++++++++++++++++++++++++++++                            
                         ++++++++++++++++++++++++++++++++++++++++++++++++++                         
                      ++++++++++++++++++++++++++++++++++++++++++++++++++++++++                      
                   ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                   
                 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                 
               ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++               
             ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++             
            ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++            
          ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++          
         ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++         
       -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++       
      -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++      
     ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++     
    -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++    
    +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++   
   +++++++++++++++++++++++++------++++++++++++++++++++++++++++++++------+++++++++++++++++++++++++   
  ++++++++++++++++++++--.            .--++++++++++++++++++++--.            .--++++++++++++++++++++  
  +++++++++++++++++-..                  ..-++++++++++++++-..                  ..-+++++++++++++++++  
 ++++++++++++++++-.                        .-++++++++++-.                        .-++++++++++++++++ 
-+++++++++++++++.        ..-++++++-..        .-++++++-.        ..-++++++-..        .++++++++++++++++
++++++++++++++-.      .-++++++++++++++-.       .++++.       .-++++++++++++++-.      .-++++++++++++++
++++++++++++++.     .-++++++++++++++++++-.      .--.      .-++++++++++++++++++-.     .++++++++++++++
+++++++++++++.     .-+++++++++++++++++++++-              -+++++++++...-++++++++-.     .+++++++++++++
++++++++++++-     .-++++++++++++++++++++++++.          .+++++++++++.  -+++++++++-.     -++++++++++++
++++++++++++.     .+++++++-----------++++++++-.      .-++++++++----.  .---+++++++.     -++++++++++++
++++++++++++.     .++++++-.         .+++++++++.      .+++++++++.         .-++++++.     .++++++++++++
++++++++++++.     .++++++--.........-++++++++-.      .-++++++++-....  .---+++++++.     -++++++++++++
++++++++++++-     .-++++++++++++++++++++++++.          .+++++++++++.  -+++++++++-.     -++++++++++++
+++++++++++++.     .-+++++++++++++++++++++-              -+++++++++...-+++++++++.     .+++++++++++++
++++++++++++++.     .-++++++++++++++++++-.      .--.      .-++++++++++++++++++-.     .++++++++++++++
++++++++++++++-.      .-++++++++++++++-.       .++++.       .-++++++++++++++-.      .-++++++++++++++
-+++++++++++++++.       ...-++++++-...       .-++++++-.       ...-++++++-...       .++++++++++++++++
 ++++++++++++++++-.                        .-++++++++++-.                        .-++++++++++++++++ 
  +++++++++++++++++-..                  ..-++++++++++++++-..                  ..-+++++++++++++++++  
  ++++++++++++++++++++--.            .--++++++++++++++++++++--.            .--++++++++++++++++++++  
   +++++++++++++++++++++++++------+++++++++++++++++++++++++++++++++-----+++++++++++++++++++++++++   
    +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++   
    ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++    
     ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++     
      -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++      
       -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++       
         ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++         
          ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++          
            +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++           
             ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++             
               ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++               
                 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                 
                   -+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                   
                      ++++++++++++++++++++++++++++++++++++++++++++++++++++++++                      
                         ++++++++++++++++++++++++++++++++++++++++++++++++++                         
                            -+++++++++++++++++++++++++++++++++++++++++++                            
                                 -+++++++++++++++++++++++++++++++++                                 
                                       --+++++++++++++++++++-                                       

#189ba1

Love the ASCII art! But we set a limit for width and height, and just looking at this it's a little big. Would you want to make a pull request? No Rust experience needed!

[Sh4rk-Byte]

I'm sorry but I'm not that expirienced in using GitHub, I don't know how to make a pull request on a public repo

[spenserblack]

Got it, no pressure.

I'm going to mark this as "help wanted" to open this issue up for anyone else to contribute. But making a PR is easy (IMO).

1. Go to the repo's homepage and click the "fork" button
2. In your fork, create a new branch (optional)
3. Make your changes
4. GitHub should be smart enough to notice you've made changes and prompt you to create a PR. If not, you can go to this link to create a PR.

You might want to check this out: https://github.com/skills/introduction-to-github

But no pressure if you don't want to 🙂

[spenserblack]

Off-topic: @o2sh The emojis in labels are pretty, but it looks like we're not discoverable by sites like https://goodfirstissues.com. Just an FYI

[Sh4rk-Byte]

And by making changes you mean adding the ASCII art txt file?

[spenserblack]

We have contributing guidelines in CONTRIBUTING.md. It's a pretty standard filename, so if you're looking to contribute to a repo, checking if this file exists is a good place to start.

Basically, languages.yaml defines everything we need to add a new language. So you can edit that file in your fork and make a PR. Don't worry if you're not confident about your changes -- we can offer feedback in the PR.

And when we merge your PR you can brag about being a contributor for onefetch 😉

[Sh4rk-Byte]

Ok, but how do I create PR on this repo, when I did the edits in my forked one?

[spenserblack]

When creating a PR you can change the base repository, which could also be thought of as the target repository. I went ahead and made the PR for you, though 😉 #1173

[Sh4rk-Byte]

Oh I overlooked that thank you. So other than the review it's done?

[spenserblack]

Yeah pretty much. You might want to subscribe to #1173 so you're notified when we add comments.

[o2sh]

Off-topic: @o2sh The emojis in labels are pretty, but it looks like we're not discoverable by sites like https://goodfirstissues.com/. Just an FYI

Thanks for pointing that out @spenserblack, I created an issue on their repo iedr/goodfirstissues#57

[spenserblack]

Thanks for finding the repo!

Looks like this is the relevant query: https://github.com/iedr/goodfirstissues/blob/36dde6c91654287fc84eaf657dfcce0eccf72284/backend/main-to-file.go#L68-L81

[spenserblack]

Closed in #1176