GithubHelp home page GithubHelp logo

apidocs's Introduction

apidocs's People

Contributors

aianus avatar atyang avatar cyip avatar eramazankhani avatar gershbn avatar jason-oanda avatar jmunnings avatar markyv avatar mrpoulin avatar pxr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

apidocs's Issues

misleading overview documentation

Found a few problems with the documentation

  • docs say "/v1/instruments/:instrument/candle" when it's actually "/v1/instruments/:instrument/candles"
  • POST "/v1/users/:username" doesn't do anything. (actually post "/v1/users"?). It probably should be "PUT" "/v1/users/:username" since you know the resource name ahead of time, or POST "/v1/users"

I was frustrated /v1/instruments/price wasn't working, but I didn't realize it needed a parameter and I could "drill down" on the overview for more details.

GET /v1/accounts account information

Is there a way that this call can return accountIds with additional infos like accountType, home currency etc...
Right now it is only returning a comma separated account ids.

Inconsistent names for transaction ids

Please make the keys for the transactions ids the same. Currently the response from opening a trade is "opened" and 'id" for modifying and closing a trade. Instead, change everything to "transactionId".

This is the response when a trade is opened
{
closed = ();
instrument = "EUR_USD";
interest =();
marginUsed = "6.11";
opened = 176203144;
price = "1.2598";
side = buy;
time = "2013-05-28T15:59:18Z";
units = 97;
updated = 0;
}

This is the response when a trade is modified
{
id = 176203144;
instrument = "EUR_USD";
price = "1.2598";
side = buy;
stopLoss = 0;
takeProfit = 0;
time = "2013-05-28T15:59:18Z";
trailingStop = 0;
units = 97;
}

This is the response when a trade is closed
{
id = 176203144;
instrument = "EUR_USD";
price = "1.2598";
side = buy;
stopLoss = 0;
takeProfit = 0;
time = "2013-05-28T15:59:18Z";
trailingStop = 0;
units = 97;
}

In consistent time formats for instruments and trades

Is there a reason why the time format is different for instruments and trades?

Instrument uses UTC millisecond time and trades/orders uses UTC RFC3339 formatted time.

Can we be consistent and use the same time format everywhere?

Streaming rates instrument naming conventions

Streaming rates is great! However it currently seems to use instrument display names rather than the instrument names returned by /v1/instruments. Maybe it (and other parts of the API) could accept "EUR_USD" as well as "EUR/USD", for example.

Feature request: Streaming rates

At the moment streaming rates are only available through FIX and Java API. Would be great to have similar functionality through REST API, simple socket or MQ.

Pagination problem

GET /v1/accounts/:account_id/orders
GET /v1/accounts/:account_id/trades
GET /v1/accounts/:account_id/transactions

Each of these is currently including "nextPage" even when there are no further items to retrieve. "nextPage" is only omitted from a response with zero items

This results in having to do a redundant query to get a final page with no items.

"nav" value missing from account details responses

Despite being documented the "nav" value is currently missing from server responses:

GET /v1/accounts/8139117

{
"accountId" : 8139117,
"accountName" : "Primary",
"balance" : 100000,
"unrealizedPl" : 0,
"realizedPl" : 0,
"marginUsed" : 0,
"marginAvail" : 100000,
"openTrades" : 0,
"openOrders" : 0,
"marginRate" : 0.05,
"homecurr" : "GBP"
}

Also, shouldn't "homecurr" be "homeCurr"?

Creating more that 26 open trades is not permitted

If there are 26 open trades any additional attempts to open another trade generates a 403 error:
HTTP error code : 403 Msg: Forbidden Request

This trading limit is not present on the current Oanda API.

missing fields in response to trade request

Hello,

this is the server response to a trade (POST /v1/accounts/:account_id/trades):

{
"ids" : [
178471630
],
"instrument" : "EUR_USD",
"units" : 654127,
"price" : 1.31661,
"marginUsed" : 43061.5075,
"direction" : "short"
}

The following fields are missing:

"time" : ,
"takeProfit" : ,
"stopLoss" : ,
"trailingStop" : ,

thanks

Inconsistent naming for high and low limit prices

In orders, trades and transactions these are variously named "highLimit", "highPrice" and "highOrderLimit" and "lowLimit", "lowPrice" and "lowOrderLimit". Some consistency might be helpful to a developer.

please add 'id' field to v1/instruments

1 EUR/USD
2 EUR/GBP
3 EUR/JPY
4 EUR/CHF
5 USD/JPY
6 USD/CHF
7 USD/CAD
8 GBP/USD
9 GBP/JPY
10 GBP/CHF
11 AUD/USD
12 AUD/CZK
13 AUD/DKK
14 AUD/HKD
15 AUD/HUF
16 AUD/JPY
17 AUD/MXN
18 AUD/NOK
19 AUD/NZD
20 AUD/PLN

... and etc.

Transaction history needs time based retrieval

This may be an oversight but time based retrieval is supported by the website but not here. While minTransId and maxTransId are useful for pagination most operations on transaction history are based on time - today, yesterday, last week, this week, etc. The proposed implementation without minTime and maxTime requires a developer to maintain a local database of transaction history for typical analyses and is not much use for ad hoc queries.

Account creation returns a 502 Bad Gateway error

Creating a new account via
POST http://api-sandbox.oanda.com/v1/accounts

Returns a 502 Bad Gateway error.

Test using:
https://apigee.com/oandapoc/embed/console/oanda?req=%7B%22resource%22%3A%22accounts%22%2C%22params%22%3A%7B%22query%22%3A%7B%7D%2C%22template%22%3A%7B%7D%2C%22headers%22%3A%7B%7D%2C%22body%22%3A%7B%22attachmentParamName%22%3A%22file%20attachment%22%2C%22attachmentFormat%22%3A%22mime%22%2C%22attachmentContentDisposition%22%3A%22form-data%22%7D%7D%2C%22verb%22%3A%22post%22%7D

Also, the new method of creating an account does not allow the ability to set the currency The Account controller no longer has a Currency parameter as there was previously with:

-#### Request

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.