oasis-main / oasis-rpi Goto Github PK

Hi,

first of all - awesome project!

I stumbled over some minor things here:
https://github.com/oasis-iot/grow-ctrl/blob/b9409719e04754bd89f3abca79bd002c3965d689/lightingElement.py#L32

The file handler is closed twice. Once implicitly in the 'with' clause and once directly afterwards. When using 'with' you do not need to close the handler by yourself (see: https://stackoverflow.com/questions/17459867/file-open-and-close-in-python).

Also you could move the 'GPIO.cleanup()' outside the try-except block as it should be executed anyway (bottom of the file).

Best regards,
Maurice

Edit: The double-close occurs in many of the other files as well

• pull data from data-out/PID return, etc
• reliably kill child process on parent exit

Sometimes when getting packages to download, the connection times out, causing that part of the setup to fail. However, the script continues to run, and it is unclear whether or not the installation has been a success.

Set up some sort of flag that will be tripped upon device deletion, enables the listener to exit gracefully