Comments (4)
IMO the clearing should happen on every change. Person might forget what he intended to do and might forget to change the value. Calculating some scenarios just complicates everything. I don't see the problem with providing values on token change
from oasis-direct.
@pimato
Mmm but which behavior you would use in this case?
Let's put some examples:
- I'm selling 1 ETH for DAI, a DAI value shows up. Then change DAI to MKR. This case I think is quite straight forward. I can imagine the MKR value will be calculated.
- I'm selling 1 ETH for DAI, a DAI value shows up. Then change ETH to MKR. Should I calculate selling 1 MKR and get the DAI value, or keep the DAI value and get how much MKR do we need?
- I'm selling 1 ETH for DAI, a DAI value shows up. Then we switch the coins, should we keep 1 ETH buying or the DAI amount as selling?
I think is even more complicate to decide when you are selecting the buy amount.
So we should put a simple rule to do always the same or specify case by case what we want to do.
I'm not sure if there is a natural way to decide, that is why I've opted to clean the inputs, so the user never gets confused.
from oasis-direct.
@pimato @peculiarity As we discussed with Thomas, we are leaving this issue on hold for now.
from oasis-direct.
closed until it will be necessary to open it up again.
from oasis-direct.
Related Issues (20)
- Notification about completing conversion
- Rounding/Inputfield Issue
- What's the fifth paremeter in the offer function?
- Disclaimer box should have a different behaviour
- Oasis.direct 2 - Requirement List HOT 1
- Landing page - Adding Navigation HOT 1
- Tax Exporter Wireframes HOT 2
- Oasis Direct 2 - Design HOT 1
- Filled Inputfields should be truncated to 5 decimals
- Change message - transaction is taking longer
- When selling 0.03 ETH worth of MKR transaction fails with misleading MM comment HOT 5
- Calculating gas cost is triggered on each new digit entered
- Input fields getting cleared
- Oasis.Direct Technical Documentation HOT 3
- Recalculation of price after prolonged period of user's inactivity
- Transaction execution error on gas cost calculation HOT 1
- FAQ Design
- CSV file with information about past trades
- Adblockers can cause Export Trades to fail HOT 3
- Oasis Direct as Widget that can be Embedded
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oasis-direct.