GithubHelp home page GithubHelp logo

Comments (4)

peculiarity avatar peculiarity commented on August 21, 2024 1

IMO the clearing should happen on every change. Person might forget what he intended to do and might forget to change the value. Calculating some scenarios just complicates everything. I don't see the problem with providing values on token change

from oasis-direct.

gbalabasquer avatar gbalabasquer commented on August 21, 2024

@pimato
Mmm but which behavior you would use in this case?
Let's put some examples:

  1. I'm selling 1 ETH for DAI, a DAI value shows up. Then change DAI to MKR. This case I think is quite straight forward. I can imagine the MKR value will be calculated.
  2. I'm selling 1 ETH for DAI, a DAI value shows up. Then change ETH to MKR. Should I calculate selling 1 MKR and get the DAI value, or keep the DAI value and get how much MKR do we need?
  3. I'm selling 1 ETH for DAI, a DAI value shows up. Then we switch the coins, should we keep 1 ETH buying or the DAI amount as selling?

I think is even more complicate to decide when you are selecting the buy amount.
So we should put a simple rule to do always the same or specify case by case what we want to do.
I'm not sure if there is a natural way to decide, that is why I've opted to clean the inputs, so the user never gets confused.

from oasis-direct.

gbalabasquer avatar gbalabasquer commented on August 21, 2024

@pimato @peculiarity As we discussed with Thomas, we are leaving this issue on hold for now.

from oasis-direct.

pimato avatar pimato commented on August 21, 2024

closed until it will be necessary to open it up again.

from oasis-direct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.