odb / shml Goto Github PK

The current abstraction of tests tests.sh sourcing *_tests.sh files makes it harder to tell where the error is coming from. Tests need to be reworked.

Add confirm with usage like so:

# with success callback
on_succes() {
    echo "Success"
}
confirm "Did you succeed?" "on_success"

# with success and failure callbacks
on_failure() {
    echo "Failed"
}
confirm "Did you succeed?" "on_success" "on_failure"

# w/o callbacks
config "Did you succeed?" && echo "Why yes, yes I did!"

@jdorfman thoughts?

shunt includes shml, therefore tests are running against that version and not the local shml... no good.

Need to replace redcarpet with kramdown:

The page build completed successfully, but returned the following warning:

You are currently using the 'redcarpet' Markdown engine, which is no longer supported by GitHub Pages and may cease working at any time. To ensure your site continues to build, remove the 'markdown' setting in your site's '_config.yml' file and confirm your site renders as expected. For more information, see https://help.github.com/articles/updating-your-markdown-processor-to-kramdown/.

The problem is when we switch to Kramdown we have issues with rendering:

Error Message

/usr/local/bin/shml:360: = not found

Line 358 - 365

# Usage / Examples
##
if [ "$0" == "$BASH_SOURCE" ]; then

if [[ $@ =~ .*-v.* ]]; then
  echo "shml version ${SHML_VERSION}"
  exit 0
fi

• Update Homebrew
• Tweet
• Promote on BootstrapCDN?
• Update npm
• Update nokogiri ~> 1.8.2 - https://cl.ly/1I2v2p2c313T
• Fix latest e.g. https://raw.githubusercontent.com/odb/shml/latest/shml.sh

Runnable got acquired and shut down the service.

Need to remove the "Demo on Runnable" images in docs and README

@jmervine is this something we need to worry about?

https://github.com/odb/shml/network/dependencies#30372747

I'd like to add an installer modeled after the one used in odb/shunt. Not sure about the adding to path though, as this isn't technically an executable. If done, I'm thinking it could be sourced with:

source "$(which shml.sh)"

Feedback welcome.

Hi, I created Awesome package manager and I can install your repo using it.

After installing the Awesome:

awesome -i odb/shml shml.sh

If you can put it in your README, it will be awesome.

Thanks.

Shin

Please remove Apple from something that is connected to the FSF.

My bash prompt work incorrect when use shml.
If prompt line too long, then text will overwrite the screen of current line and hard to see.

This bug appear because non-printable sequences. I fix this after add "\[" and "\]" in fgcolor and bgcolor.

Further reading:

• https://www.gnu.org/software/bash/manual/bashref.html#Controlling-the-Prompt

PR
#51

Keep getting this:

I haven't been able to confirm if this is isolated to me or not, @jdorfman mind testing on a Mac? I'm running on Ubuntu / xterm.

Somehow the source instructions was added under npm install. It should be removed.

Link: https://odb.github.io/shml/getting-started/#Install

cc: @Mandihamza