odestry / adastra Goto Github PK

WHY are these changes introduced?

These changes are intruced to fix one issue with entrypoint files. Currently when you cant to make an entryoint file you have to do it in 2 steps:

1. Create the entrypoint file inside the root direcotory (default src)
2. Add entrypoint render liquid tag

This means that any file inside the root will be considered as an entrypoint file, which will generate useless files and they will be copied to the assets folder without them being used.

This problem needs to be adressed as soon as possible, because with larger project the current root file decision deosn't scale, and will produce issues where files are being copied to the assets folder, like type definition files.

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Update checklist

• I've added a CHANGELOG entry for this PR
• I've considered possible cross-platform impacts (Mac, Linux, Windows).
• I've left the version number as is (we'll handle incrementing this when releasing).
• I've included any post-release steps in the section above (if needed).

My machine uses rbenv and indeed I have ruby 3.1.2 and 3.2.0 installed, but for some reason, Shopify CLI bugs out on me not having 3.1.0 which is kinda dumb on that tooling.

yarn dev --store=booger-wooger.myshopify.com
Adastra Initiating launch sequence for booger-wooger store

To run this command, log in to Shopify Partners.
👉 Press any key to open the login page on your browser
✔ Logged in.
── external error ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Error coming from bundle install

Command failed with exit code 1: bundle install
rbenv: version `3.1.0' is not installed (set by /Users/gimpygumpy/Documents/Shops/2023/adastra/node_modules/@shopify/cli-kit/assets/cli-ruby/.ruby-version)

I am stuck at adastra initializing launch sequence. after running npm run dev i am already login to my store.

So there is a link provided as:

 Customize this theme in the Theme Editor, and use 'theme pull' to get the changes:

And that indeed loads up the theme in the store, and one can preview/customize. The thing is, this comes with a glitchy experience where the Theme Editor relentlessly issues POST requests to Shopify, simply by hovering the mouse around theme editor, not doing anything... not editing anything anyway. I have not seen this poor behaviour before, and it likely has nothing to do with Adastra, but man, it sucks. Poor experience anyway... Shopify needs to do better me thinks.

Please confirm that you have:

• Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
• Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

CLI

Expected behavior

Hi Adastra team,

I'm using Adastra for the first time on my client project. I'm using custom fonts in the assets folder, but when I run npm run build, the custom fonts are removed.

How can I run the build command without deleting my custom fonts?

Thanks,
Ulziibat

Actual behavior

When I run npm run build, the custom fonts are removed.

Stack trace

No response

Reproduction steps

1. copy the custom fonts to the assets folder
2. npm run build
3. custom fonts are removed

Operating System

Mac OS Monterey

Adastra CLI version (check your project's package.json if you're not sure)

latest

Shell

zsh

Node version (run node -v if you're not sure)

v20.0.0

What language and version are you using in your application?

ruby 3.0.4p208 (2022-04-12 revision 3fa771dded) [arm64-darwin21], git version 2.40.1

Get started template

1 - Added an images banner for Adastra
2 - Add workflow badges
3 - Add a getting started guide
4 - Added a link to example demo in the link page
5 - Simplifier and remove usless files
6 - Explain that this is a beta access repo

┏━━ Error ━━━━━━━━━━━━━━━━━━
┃ The option --overwrite-json is not supported.
┗━━━━━━━━━━━━━━━━━━━━━━━

My config:
node --version
v16.14.0

yarn --version
1.22.19

shopify version
3.43.0

WHY are these changes introduced?

Currently, the plugin imported from the Barrel Shopify Vite repository has a secondary entry points directory to support the second modules Vite plugin, since we don't use modules we should instead remove the code used by this Plugin inside Adastra plugin to avoid any issues in the long run.

No context.

WHAT is this pull request doing?

This PR removes unused code and tests used by the modules Vite plugin.

How to test your changes?

Post-release steps

Update checklist

• I've added a CHANGELOG entry for this PR
• I've considered possible cross-platform impacts (Mac, Linux, Windows).
• I've left the version number as is (we'll handle incrementing this when releasing).
• I've included any post-release steps in the section above (if needed).

WHY are these changes introduced?

These changes are introduced to update the two templates that originally come with Adastra, and also to add a README to the root templates folder, explaining how templates work, and hot scaffold an Adastra project from existing templates.

WHAT is this pull request doing?

• Add standard theme linting to check for errors.
• Add README to the root /templates folder.
• Add both templates to the mono repo.
• Update the templates and remove non-used code like Codespaces integration.
• Update packages.json for required changes.
• Add theme check CI to workflows

How to test your changes?

• Manual test by running Adastra CLI commands in the root of the theme folder and Checking for console errors, when in development mode.
• Run theme check to see if there are any errors with the two templates.
• Run the two development servers separately without using the CLI.
• Check if Liquid and src file changes are enabled through HMR and HOT RELOAD.

Post-release steps

Update the two templates repositories with the new changes. For basic template and minimal template

Update checklist

• I've added a CHANGELOG entry for this PR
• I've considered possible cross-platform impacts (Mac, Linux, Windows).
• I've left the version number as is (we'll handle incrementing this when releasing).
• I've included any post-release steps in the section above (if needed).

What area(s) will this request affect?

Examples

What type of change do you want to see?

New feature

Overview

I'm concerned about id conflicts if there are multiple Sections on the same page, since I do it for id elements when I create them in React. Therefore, I think it would be better to be able to prepare it in WebComponents. Thus, Preact and lit are good examples, but we would also like to use Hydrogen's functionality. So if this is feasible, I would like to see an example.

Motivation

I was working on Theme App Extension with Preact + Tailwind + WebComponents and thought how happy I would be if I could develop the theme itself with the same experience. That's when I found this repository and asked a question.