odonno / modern-gitter-winjs

Windows 10 client of gitter, written in WinJS

modern-gitter-winjs

A Gitter client application for Windows 10 based on WinJS and Angular frameworks. This project is a second iteration, starting from the previous project : Modern Gitter.

Features

Modern Gitter contains a small set of features that directly target Gitter API. Here is the key features :

• Join a new or existing room
• Retrieve your current rooms
• Search among your current rooms
• Chat in realtime (see & send messages)
• Receive realtime notifications (in-app notifications)
• Receive delayed notifications (toasts notifications : unread items and mentions)

Frameworks

This project makes use of several frameworks like :

• WinJS
• winstrap
• angular
• ui-router
• faye
• gulp

Contribute

You can contribute to this project. There is several rules to follow :

• Use the angular git commit convention
• Create Pull Request with an understandable title and a short message that explains your contribution
• Be free to innovate !

Getting started

In order to contribute, you should clone this repository and install some packages.

npm install

Then, you will need to use gulp task automation tool. So, install it globally.

npm install -g gulp

Finally, run gulp to execute task and compile angular app anytime you make a change.

gulp

Commit convention

We follow the angular git commit convention (https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#-git-commit-guidelines). Here are some examples that can help you to visualise how to make meaningful commits.

When fixing a bug with the notifications

fix(notifications): remove call that push twice the same notification

When adding a new feature related to notifications

feat(notifications): add push notifications when someone mentions user

When fixing an issue with the build / improving the build system

chore(app): improve build system

When adding some documentation

docs(readme): add a contribute section

List of contributors

I want to thank the following contributors who have helped me all along this project.

• @gep13
• @bobmulder
• @wassim-azirar
• @NPadrutt
• @corentinMiq

modern-gitter-winjs's Issues

Back Button on Windows Phone 10 not working as expected

Steps to reproduce

1. Click on Rooms
2. Select a Room
3. Click Back
4. Expectation is that the Rooms list will be shown
5. Actual result is that nothing happens
6. Click Back again
7. Application exits

Chat privately

Toast notifications do not support '<' or '>' characters

Problem with images in room

I noticed an issue in a couple rooms when using the application this morning.

When I entered each room, there were images posted into some of the messages, and the text from other messages were over the top of the images. I was hoping to get a screenshot of the problem, but when I got to my computer and opened the rooms again, the images are appearing correctly.

If it happens again, I will update this issue with a screenshot.

Icons in the splitview are treated like text

Message is sent mutliple times

Transition from/to error page when we lost network connection

Like in the Windows Store app, when we lost/retrieve network connection, the app should automatically navigate to an error page that said we lost network connection.

How to Sign Out?

"undefined" in notification messages

Not sure what this is, but I think there is something not quite right here:

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

Show last accessed chat when loading app

I get notifications for my own messages

Since I wrote this message, I don't need to get a notification about it 😄

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

Disable notifications of the app

On the device only :

• Add ability to disable notifications for all rooms (entire app)
• Add ability to disable background notifications

Unread message count icon is always shown

When looking at the Rooms screen, I always see an unread message count icon, even though these say 0 unread messages.

I think the unread message icon should only be shown when the unread message count is greater than 0 for any given room.

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

Clicking on Repository crashes app

Join Room
Repository
crash

Authenticated with Twitter

Application Crash when no internet connection

Steps to reproduce

• Put phone into flight mode (to simulate no network)
• Start application

Expected Result
Application should start normally with stored messages available to browse

Actual Result
Application crashses

Application Version
2.2.53

Disable notifications of a single room

Add ability to disable notifications of a new message in a room (room settings).

Issue with marking messages as read

After entering a room, in order to mark messages as read, you have to "move" the listview.

I can understand that when it comes to messages that are off the screen, but entering a room that has only three unread messages (for example) should result in those messages being marked as read, after a time delay, without any interaction from the user, similar to the way the web site works.

Problem viewing messages within room

With the latest release of the UWP application, I am seeing an issue viewing the messages within a room.

For example, when going into the Odonno/Modern-Gitter chat room, I see a completely blank screen. If I scroll up and down, the messages sometimes appear, but then the screen goes blank again. Other times, the messages stay in place, but then the messages jump to the last message in the room.

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

About page

Back key navigation looks unnatural on mobile

I think that back key navigation is not compatible with hamburger menu.
Who agrees that he does not expect to go to previous page by pressing back key but navigate away to previous app?
It looks somewhat strange to navigate to some page while menu is available.

Dark template

Add progress indicator when message is being sent

When send button is pressed user have no idea what is happening. Until sometime after message can appear not appear in thread.

Fade of room header when scrolling

Support emoji

https://github.com/globaldev/angular-emoji-filter

Change startpage to rooms

Currently the start page is the "welcome to gitter" page. While I think it's a good idea to have such a page where you can introduce your self I wouldn't define this as the start page.
First doesn't it offer any information I need when I use the app, second after the first time I saw it I don't get any new information. Therefore after the first 3-5 starts it's just an annoying click to get to my rooms.

I would move this Menu point to the bottom of the list with menu entries, set rooms to the top and make this the default page since joining a existing room probably will be the command a user will use the most.

In-app badge notification is not updated when a new message arrived

Leave a room

Back Button should respect page navigations

Steps to reproduce:

1. Open Application
2. Open Hamburger Menu
3. Click Rooms
4. Click on a room
5. Click back button

At this point, I would expect the application to return to the list of rooms, however, the application exits.

Attach images in chat

Mark unread messages when they are visible on listview

Notification Messages in Action Center should clear once the room has been visited

This is a similar request to what was made for the Windows Phone version of the application.

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

Toggle favourite room

Add ability to search room by name or tag

Add ability to search room by tag like in the website https://gitter.im/home/explore

Example : https://gitter.im/api/v1/rooms?q=node&limit=50

Hamburger menu should disappear when you click on an option

Steps to reproduce:

1. Open the Modern Gitter Application
2. Click the hamburger menu
3. Click Rooms

At this point, the hamburger menu that popped out should disappear and show me the chosen selection, i.e. the rooms screen.

Instead, the hamburger menu remains in place, and you have to click to the right of the menu in order to see the rooms, which is not ideal.

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

Filter rooms by tag

Edit a message

Send notifications of unread messages when we're offline

Should handle launch from toast notification

I would expect that clicking on a notification takes me to the room/private chat, that is associated with the notification.

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

Create readme.md

Avoid the possibility to join a room we are already in

Show action notification when we receive a mention

Show action notification like we can see here : http//blogs.msdn.com/b/tiles_and_toasts/archive/2015/07/02/adaptive-and-interactive-toast-notifications-for-windows-10.aspx

Touching a menu item selects it

When I open the hamburger menu and touch "Rooms", it always gets selected. Please make all texts not-selectable.

The listview of messages is jumping

The app crashes if you click too often in the menu

When tap random on different menu items with a high pace the app will crash after some seconds.

Add splashscreen

Adding splashscreen will help to initiliaze stuff before starting use of the app. It will also prevent bugs from happening like authentication.

In-app badge notification for mentions

Design chat message

Going into a room with unread messages doesn't decrease the unread count

Steps to reproduce:

1. Open the application
2. Find a room that has unread messages
3. Open the room
4. Read the messages
5. Return to room list, message count is still the same
6. Check same room on gitter.im, message count is still the same

Markdown text editor

Application always goes to the About screen on load

I totally get the idea of having the About screen, however, I don't think this should be the default screen that the application goes to on each load of the application.

Instead, I think the list of rooms should be the default screen that is opened, after the first time the application runs.

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.