GithubHelp home page GithubHelp logo

Comments (8)

Daandelange avatar Daandelange commented on September 10, 2024

I like the bottom console which allows you to trace back what happened on generating/updating projects; even after closing the success modal.
27ed863 hides the bottom console on the settings page. It can easily be hidden on the batch page too in this line: 27ed863#diff-ed5f959bb9eee3684a44c6e6ed7d1cf1R216

from pgelectron.

ofZach avatar ofZach commented on September 10, 2024

what if the console was an options only thing? I really don't think end users will need this and or understand it (vs the console output from the action). I think we should keep the UI as simple as possible here. @kylemcdonald what do you think? Personally, I feel like it's redundant.

from pgelectron.

ofZach avatar ofZach commented on September 10, 2024

(also, I've made show console tools a settings thing, you can enable it via settings.json but it's not an "option" for end users...)

from pgelectron.

Daandelange avatar Daandelange commented on September 10, 2024

Ok, now it makes more sense to me.

This is how I see it now:

  • An end-user option to "Show console messages" shows console feedback after each operation. (toggle btn if success, always shown if error) [it vanishes on closing the modal]
  • Another hidden option shows the console at the bottom of the page which keeps track of all console history.

And as I said in #20 (comment), IMO it's still weird not to show the console messages if an error occurred. So maybe if the "Show console messages" setting is off, we can show a toggle button when an error occured. (?)

from pgelectron.

ofZach avatar ofZach commented on September 10, 2024

how about a show console messages button on the success / failure overlay and not in options? we could show console in failure, but in success make it an option? (that way, we keep it out of settings).

I like the hidden option, so if you (or anyone) wants to monitor everything they can, but I don't think this is a normal need people will have.

from pgelectron.

Daandelange avatar Daandelange commented on September 10, 2024

Sounds good too.
So:

  • No UI setting for "Show console" but always show it on success[toggle] / failure modals
  • A hidden settings.json setting lets you enable the console at the bottom of the generate pages.
  • (maybe) a PG readme states that more settings are available in settings.json

from pgelectron.

kylemcdonald avatar kylemcdonald commented on September 10, 2024

I'm for removing it completely, and only showing feedback on errors. The
use case for it is "something went wrong and I want to copy this message
and ask on the forum", which the dialog allows.

I don't see a use case for showing the console in any other case, except
during development of the PG itself, which is not an end-user facing
application.

On Monday, August 24, 2015, Daan de Lange [email protected] wrote:

Sounds good too.
So:

  • No UI setting for "Show console" but always show it on success[
    toggle] / failure modals
  • A hidden settings.json setting lets you enable the console at the
    bottom of the generate pages.
  • (maybe) a PG readme states that more settings are available in
    settings.json


Reply to this email directly or view it on GitHub
#24 (comment).

from pgelectron.

Daandelange avatar Daandelange commented on September 10, 2024

Ok, this last commit changes it like that.

  • Console feedback is only shown on errors.
  • There's a hidden console setting allowing to see all console feedback.

Is this how we want it ?

from pgelectron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.