A Bunq web interface made by bunqers
Home Page: https://bunqweb.com
License: MIT License
![greenkeeper[bot] avatar](https://avatars.githubusercontent.com/in/505?v=4 "greenkeeper[bot]")
There is no need to make 3 API calls (Load file button) to restart a session
The web app does not look good on small screens(mobile). The charts gets to small and the table malformed.
https://sentry.io/share/issue/3137323731332e323832303338353734/
IndexError: list index out of range
(5 additional frame(s) were not displayed)
...
File "BunqAPI/views.py", line 128, in post
response = getattr(API, selector.strip('/'))()
File "BunqAPI/callbacks.py", line 255, in invoice
return get_pdf(json.dumps(r['Response'][0]['Invoice']))
IndexError: list index out of range
When there are no invoices for an user IndexError wil be raised. Instead there should be a response telling the user that there are no invoices found
In the current version, the user must walk through a lot of steps. A lot of things can be automated, for example:
Another big killer of the user-friendlyness is all the different menu's. It would be better to 1 main page which leads you to the next, for example.
Homepage -> log in -> Upload .json -> Main screen for api calls
Register -> create account -> set up 2fa -> log in -> main screen for api calls
This way, the user doesn't have to search for pages like "/Setup 2fa", "/Login" or "/decrypt (which is actually sortof the main page)".
Class based views will make the code look cleaner and better.
It seems that the current login system is overkill. Instead of using 2fa on your phone, it will be rebuild that you just need an account password and your json to login. This decision was made based on user feedback.
Let user know if there was an mistake in decrypting the JSON
Migration service for old accounts to a new an new account
Explanation on the download page
Session aware
Save session-server response and Avatar in session
Delete/extend session when user logs back in and session-server has not yet ended
https://sentry.io/share/issue/3137323731332e323832343033333536/
KeyError: 'Response'
(5 additional frame(s) were not displayed)
...
File "BunqAPI/views.py", line 128, in post
response = getattr(API, selector.strip('/'))()
File "BunqAPI/callbacks.py", line 91, in load_file
self.accountID = accounts['Response'][0]['MonetaryAccountBank']['id'] # noqa
KeyError: 'Response'
It seems that the sleep of 1.5 seconds is not enough.
There seems to be an issue in the html5up template's main.js file which is causing this error:
TypeError: $('form').placeholder is not a function. (In '$('form').placeholder()', '$('form').placeholder' is undefined)
at ? (/static/assets/js/main.7c8a1758d363.js:36:25)
at j(/static/jquery/dist/jquery.min.c9f5aeeca3ad.js:2:30004)
at ? (/static/jquery/dist/jquery.min.c9f5aeeca3ad.js:2:30314)
at this(raven.js:379:34)
When user inputs his/her CSV data the Pie's wont get catagories like in the example at the top of the page. This can get fixed by using a catagory filter stored in the DB.
Todo
Categorize text input
categorize file input
The transactions table is not sorted right. It seems like the deployed version and the version on my local machine (latest origin/master commit ) gets sorted differently. The date should be the first column and the description last...
When the JSON is send to the server it returns differently sorted to the client. If this gets fixed then there is no need to manually sort the columns because the original order is perfect. If not then the data needs te be resorted before its shown in the table.
If a Button is pressed once, multiple requests are send to the API view instead of 1.
The transactions table used to have a search bar where users could filter transactions, and a next/previous button to change between pages. Due to the CSS of semantic i think these buttons and input boxes are gone. Need to find a way to manually create these boxes or find a way with the CSS.
Error in console:
decrypt.js:241 Uncaught ReferenceError: numeral is not defined
at createTable (decrypt.js:241)
at Object. (decrypt.js:137)
at i (jquery.min.js:2)
at Object.fireWith [as resolveWith] (jquery.min.js:2)
at A (jquery.min.js:4)
at XMLHttpRequest. (jquery.min.js:4)
Tested in template branch.
When pressed twice on textCSV or fileCSV a table gets created inside another table, instead off refreshing.
Will make the table hidden at page load and visible once there is data to show. This will remove the horizontal line on the page where the table will appear when there is contents to show.
The jango-bower package is supposed to make the bower static files handling easy but this is not the case. It should work like this:
./manage.py bower install./manage.py collect staticWhen run collect static it should move all the bower files to the /static-files folder, which it does correctly. When the project is run locally it works smooth. For some reason on heroku it doesn't, the files get moved correctly to the static-files folder but it seems that heroku is reading the files from static. Not sure whats causing this, may have something to do with a misconfigured whitenoise settings.py.
To use the bunq api there is a need of a static API. A solution for this can be QuotaGuard Static, however i don't think 250 requests are enough. Will wait and see if bunq is going to remove this requirement or not before i implement this.
This also means that in release V0.3.0-beta.2 API calls will fail.
test_Manager should be passing but for some small reason its not. According to my calculations the values off shouldBeReturned are correct but its still returning false. This might be related to #18 ?
Title speaks for itself
Pages need proper HTML and CSS
ATM, instead of using 1 session and adding variables to that session, a new session is created for each variable.
Need to use one session and store al variables in this one session.
When a user exports an CSV from the decrypt page, it doesn't work on the /Manager page.
On the /Maanger page users can upload an CSV with transactions and these get categorised and sorted. However I've kind of hard coded the code to only work with exported CSV from the bunq app. Need to rewrite the code to accept both, exported CSV from ComBunqWeb and bunq app
Why do you use UUIDGenerator.net in installation.py?
Why not:
import uuid
def get_GUID(self):
GUID = uuid.uuid4()
return GUID
https://sentry.io/ogkevin/combunqwebapp/issues/281090296/
KeyError: 'json'
File "django/utils/datastructures.py", line 83, in __getitem__
list_ = super(MultiValueDict, self).__getitem__(key)
MultiValueDictKeyError: "'json'"
(5 additional frame(s) were not displayed)
...
File "BunqAPI/views.py", line 106, in post
file_contents = json.loads(request.POST['json'])
MultiValueDictKeyError: "'json'"
If the file has not been loaded correctly via JS, need to cancel the ajax call
The current .travis.yml is not configured correctly.
Atm there is only one main url config which is not clean and easy to read. Need to give each module its own url config.
ATM i have to manually turn sandbox on and off, logging to sentry etc.
Settings should use a Config Var to determine the settings.
The current model for storing categories in the database is not convenient. Category name and additional info needs te be stored in separate fields.
There are 2 buttons "decrypt" & "start session", however the JS code that handles these buttons does not work right. When the user presses one of these 2 buttons the encrypted file gets read and then send via POST. This does not work on the 1st press.
For it to work you NEED to press 'decrypt' once, after this the file is read correctly, now the buttons work as intended. The first press cant be "start sessions".
This issue is introduced in 43036fb#diff-8841de7cf2efee0cfe87e30986d7c694
Why use a external webservice? What if api.sycade.com has a autage or responds slowly? (What is unlikely, but possible 😄)
You can locally use ReportLab, check this: https://docs.djangoproject.com/en/1.11/howto/outputting-pdf/
For the transaction table im using Vanilla DataTables. With this table users can search/filter transaction based on keywords. My idea was to get the shown entries back and convert them to CSV for the user when an 'export' button is pressed. However as of now this module doesn't support that therefore Mobius1/Vanilla-DataTables#11. Once support of this is added I can add an export feature.
Hi 👊
This is my first visit to this fine repo, but it seems you have been working hard to keep all dependencies updated so far.
Once you have closed this issue, I'll create seperate pull requests for every update as soon as I find one.
That's it for now!
Happy merging! 🤖
Now we are trying to get the accounts and payments even when 'start session' was not successful
ATM when the load file button is pressed, javascript will make 3 ajax calls. This needs te be rewritten so that only one ajax call is made and the backend will return 1 response.
I've created a google form for the first round of data collection to expand the category filter. For now the filter wil only filter on IBANS. So when a list of transactions is send to get filtered, the scripts wil look through the transactions and add then to categories based on the IBANS where the money was sent to.
The form is very simple, insert a IBAN to the category it belongs to. One IBAN per category per submission. Before this data gets stored in the database it will go through validation.
If you want to add/remove a catagory or have a suggestion feel free to comment.
Because the app is hosted on a free Heroku account, there are limitations on how much stuff you can store in the database. To prevent the database from filling up and not saving new data, I've decided to use google forms for now.
Similar code found in 1 other location (mass = 64)
The export transactions button is not working properly in fe1a8d4
Need to fix this spelling error in the entire code.
🤦🏾♂️
https://sentry.io/share/issue/3137323731332e323833303735303535/
AttributeError: 'callback' object has no attribute '_bunq_api'
(7 additional frame(s) were not displayed)
...
File "BunqAPI/views.py", line 128, in post
response = getattr(API, selector.strip('/'))()
File "BunqAPI/callbacks.py", line 60, in load_file
accounts = self.accounts()
File "BunqAPI/callbacks.py", line 152, in accounts
r = self.bunq_api.endpoints.monetary_account.get_all_accounts_for_user( # noqa
File "BunqAPI/callbacks.py", line 308, in bunq_api
return self._bunq_api
AttributeError: 'callback' object has no attribute '_bunq_api'
Seems like the bunq_api is not set correctly.
If a IBAN is not found in the database is does not get filtered under "others"
If the user has no cards in his/her account and presses on the cards button, the loading indicator stays there forever. This is because the retuned response is empty and therefore then loader container is not getting repopulated with data.
I'm missing the installation steps, in the README or on wiki :-)
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.