Numbers should not be translated about mindtheword

[masukomi]

i'm seeing this too. It's not only that numbers shouldn't be translated, but that it translates them incorrectly. I think a more accurate bug would be that it incorrectly translates them and there's no way to disable the translation of numbers. When dealing with languages with different number notation (not 0-9) translation of numbers would actually be quite useful. For example Arabic, or Japanese numbers look nothing like ours, and it would be good practice to see them translated.

[ceilican]

From another user:

I just wanted to inform you that your application attempts to translate numbers, but ends up turning them into letters or quote marks. This can get frustrating very fast. I'm unsure if this happens with all languages, but I am using English > Japanese.

[bqv]

I'm noticing the number 0 being translated, in CSS style tags no less, in google search results. It's translated to "{", which naturally breaks all the styling. I'm also using English > Japanese

[ceilican]

From another user:

Hello, Often this extension tries to tranlate numbers, which then turn into quotation marks or something, which is really annoying. IT would be best if numbers were not translated. The Google results page becomes very messy and corruptedI think. The blacklist seems not to work. The pages I have addeed are still translated. Also, there are some pages which won't load when the extension is enabled, which is annoying. Great idea, and has been very useful, would just be great if those things could be fixed...

[ceilican]

Perhaps this issue is partially fixed by now. But this needs to be checked.

[srikar0896]

hello ceilican,
I want to resolve this bug.where can i find the repository of this?

[ceilican]

@srikar0896 Mind The Word's source code is here: https://github.com/OiWorld/MindTheWord

[srikar0896]

hey ceilican;
I've made the translate function just skip when it finds the number not to translate it.here's the link to patch file created -master...srikar0896:patch-1
Thank you

[ceilican]

Thank you, @srikar0896 ! That's a fine and simple solution. I like it! Could you please create a pull request?

[srikar0896]

Thank you.sure
On Mar 4, 2016 5:06 AM, "Bruno" [email protected] wrote:

Thank you, @srikar0896 https://github.com/srikar0896 ! That's a fine
and simple solution. I like it! Could you please create a pull request?

—
Reply to this email directly or view it on GitHub
#11 (comment).