Create button doesn't create new configurations, and user cannot change from the default latin translation about mindtheword

[RyanRusnak]

It looks like the create button is throwing a JS error:

Uncaught SyntaxError: Unexpected token u
createPattern   @   options.js:181

savedPatterns is undefined and I think that is causing the error. I think every new user will have no saved patters though. I tried adding one and still experienced the error so maybe they are not being persisted.

[ceilican]

Hi Ryan! Thanks for the information. I am still not able to reproduce the error in my computer. Therefore, I rely on people like you, who can provide more information about the error. I agree with you that this bug must be due to a persistence error, but I wonder why it is happening only to a few users. Do you have any idea?

[RyanRusnak]

You are right. Locally, the plugin works perfectly. However, installing from the chrome store causes an error. See attached screenshots for each:

[Stormteller]

I got this error, when I had tried to turn app on, before I visited options page after installation (I installed it locally). But after I had created config and opened page, nothing have changed, no one word was highlighted.

[ankit-m]

There was a null case error (S('savedPatterns') was referencing to undefined) in createPattern function. As a result new configurations could not be created. I have fixed this issue and also added duplicate configuration handling. Pull request #65

[rohankatyal29]

@ankit-m : How did you reproduce this issue?

[ceilican]

It is still puzzling that S('savedPatterns') ever references to "undefined". This should never happen. Pull request #65 is good, because it makes the extension more resistant to such "undefined" cases, but we still don't know why it is "undefined" sometimes (and only for a few users).

[ankit-m]

@ceilican this occurs during cold start. When a user first installs the extension, only then they get this error. The savedPatterns variable is undefined in the first go, which causes an exception.

Here is the original error in the extension downloaded from webstore.

The problem is with this snippet

  if (data == null || JSON.stringify(data) == '{}') { // in this case, storage was not initialized yet
        console.log('setting storage to defaultStorage (stringified): ');
        console.log(JSON.stringify(defaultStorage));
        storage.set(defaultStorage);
        d = defaultStorage;

data is NOT null NEITHER {} because it has activation: true. As a result d is not set to defaultStorage. So if someone downloads, and turns on, defaultStorage is never set. This is causing variables to be undefined. I will solve this and raise a pull request.

[ceilican]

But why does this happen only to some users?

[ankit-m]

Because only some people turn on right after installation, before going to options page which sets the activation field in data object. As a result some get the error rest do not. Should I go ahead and fix this?

[ceilican]

Yes, please go ahead!