ondrejbouda / php7backport Goto Github PK

I cloned the repo into the Composer/vendor folder. I run on Command Prompt

php converter.php "C:/User/..../..../ Php7CodeFolder" "C:/Users/.../..../Php5CodeFolder"

It give me some "Warning" -->

mkdir(): Invalid argument in C:\Users..........\Composer\vendor\php7backport\src\Bouda\Php7Backport\DirectoryBackporter.php on line 31

and a "Fatal Error" -->

Uncaught Error: Class 'PhpParser\Lexer\Emulative' not found in C:\Users.........\Composer\vendor\php7backport\src\Bouda\Php7Backport\Backporter.php:21

I don't understand why and how to resolve these errors.

Can you give me some help?

Can u do this?

foo() ?? $bar
becomes
!is_null(foo()) ? foo() : $bar

foo() is called twice. This could have side effects.

• return changed node from visitor - problem with constructors, where the input node is class, but changed node is ClassMethod
• better handling of invalidating nodes - post traversal maybe?
• fix situation, when a node changes twice (e.g. constructor + return type) - then only one of them renders

Source files to be converted:

• src/A.php
• src/B/B.php

Command I use:

php convert.php src /tmp

It will produce warning like: file_put_contents(/tmp/B/B.php): failed to open stream: No such file or directory

By adding var_dump($file); to DirectoryBackporter.php Line 28, it dumps src/A.php, src/B/B.php, src/B. So the order is not what we expected.

I made some change to DirectoryBackporter.php, which can fix this bug in 5.6. I can send you PR if you think my code is okay to use.

Hey there,

thanks for your work!

I just noticed that you're not using PHP 7 for the project's source code. Would you consider a PR adding PHP 7 features and a backported version for users of old versions (branch or phar)?

Cheers,
Mike

function (string $foo) {}
should become
function ($foo) { $foo = (string) $foo; }

Identifiers used for generated names (e.g. anonymous classes) use sequence which is reset for each converted file. Conflicts could arise.

Proposed solution: add some kind of hash to the generated name (hashed source file maybe?) to ensure uniqueness