one-acre-fund / farmr Goto Github PK

Aim of join_report

• give quick summary of result of join statement so joins don't lead to the wrong data
• simplify the process of identifying the source of an incorrect join, ie. are ids duplicated?
• ultimately can be stripped from any final code but can make the process of joining data much quicker.

@jesund I'm getting an error on loading the updated farmr package that says that 'read_that_csv' is exported in the namespace but doesn't exist in the package.

I think the fix is re-running the documentation (Cmd+shift+D) to rebuild the namespace without read_that_csv but wanted to flag it for you in case that is a function that you're working on and it should be in the namespace!

Let me know when you've fixed this and I'll download the package again.

Fails if there are missing values in the column

I think you might run into some errors when it comes to running Cmd+Shift+E to build the package. This guide to tidyeval should help.

Specifically, how make sure the dplyr programming is fully documented.

@jesund I'm using the theme_oaf() function and it's working well and looks good! I have a couple suggestions for future additions:

• Subtitles are not aligned with the title since the title is centered. Can we force alignment?
• I can't easily add a label to fill() (filling box plot or scatter plot by factor, for instance). Is there a work around?

is_duplicated failing test to only flag one instance when there are multiple duplicates. Look into this use case more.

Quickly check if values are unique

is_unique() would check length(x) == length(unique(x))

Consider adding SROI calculator to package based on standardized SROI cannibalization calculations in docs like this

Basic idea would be something like

is_duplicated() and it would give the duplicated cases
duplicated | duplicated(, fromLast = T)

This will ensure that you don't hit errors trying to compile the full package when using %>%

@jesund Hi Johnna, I couldn't get the oaf_theme markdown template to work for me but I might not have been trying it correctly! Not urgent but can you share the steps I should follow to access the markdown template? I assumed that if I loaded the farmr package that it would apply itself to that Rmd but that might have been to simplistic of me...

https://www.r-bloggers.com/writing-pipe-friendly-functions/

It's worth a quick read. Some small modifications will make sure the farmr functions are pipe compatible in scripts.