onejgordon / react-life-timeline Goto Github PK

If the ReactLifeTimeline component is created without a non-zero length events prop or without a get_events, then birthday / current_week events are never rendered.

Looks like this section should be changed to something like:

if (this.props.get_events != null && this.props.events.length == 0) this.props.get_events(this.got_events.bind(this));
else this.got_events(this.props.events);

I'm not sure how exactly this is done by @busterbenson, but it looks much prettier when the weeks are all starting with birthday.

For example, see busterbenson's site vs what react-life-timeline produces.

Since, an year can't be fit into exactly 52 weeks - I am not sure if the calendar on buster's site is dropping off the extra day (or two).