onenotedev / android-rest-api-explorer Goto Github PK

In the SignInActivity.java file there is an onError handler for signing in that is called when an error occurs. The code does not indicate that anything went wrong, so if there is a problem, the user is returned to the sign in activity with no explanation. Recommend adding a toast.

@Override
public void onError(Exception e) {
   // Recommend add a toast here for the user
    e.printStackTrace();
}

It'd be great if you could also show the request body. Thanks!

app_name string reads "OneNote REST Demo". Should be "OneNote REST API Explorer". Also the icon needs to be our standard flag icon.

This story comes out of #7 - if I were able to implement that story there'd be no need for this one.

Thanks to @DianeD for calling this out:

In the readme, it says SP site notebooks are supported, but I think not? Their URLs would include this context bit: myorganization/siteCollections/{id}/sites/{id}

… Or you can authenticate using a work or school account to connect to OneNote on either your organization's OneDrive or *SharePoint site* on Office 365.

Courtesy of @bmitchell287 👍

Can it be an affiliate of a personal account?

When the app is killed and restarted, the permission screen is shown even when offline access is mentioned in the scope. I see this happening when I log in using MSA account. I am using the app as is without modifying the gradle dependencies.

Is there any way to solve this ?

Can we add some screenshots either to the wiki or to the readme?

Currently using:

wl.signin
wl.offline_access
office.onenote_create
office.onenote_update_by_app
office.onenote_update

but @unpluggedk is only using:

wl.signin
wl.offline_access
office.onenote_create

The PATCH snippet has to pass an empty Accept-Encoding header to work without a 500 error. When this is fixed in the OneNote API, remove the code that is adding the empty header.

*stealth edit adding hyperlink to referenced code -@iambmelt

If the user has already authenticated, we shouldn't prompt them for credentials or consent again.

This snippet is failing with a 500 server error. It works on the Windows version though.