onthegosystems / wpml-page-builders-elementor

A library used by WPML to handle Elementor

This package has been merged into the WPML Page Builders addon.

---

wpml-page-builders-elementor

A library used by WPML for handling Elementor.

Packagist

Monthly Downloads

Daily Downloads

wpml-page-builders-elementor's Issues

Elementor Pro - missing Call to Action and Blockquote modules in TE

It seems that these elements are not registered for translation:
Call to Action and Blockquote

Steps:

• Install Elementor and Elementor PRO
• Create a new page and add Call to Action and Blockquote elements.
• Translate using Translation Editor.

Elementor Pro - missing modules when using Translation Editor

In the translation editor there seems to be missing the ability to translate:
-Animated modules - You can add a highlighted animation to a text. You can translate this manually via Elementor editor in the second language

-Post listing widget words for "Read more" - Can be translated as well via Elementor editor in the second language.

-Global modules for Elementor - they can be set as local and unlinked from the global module and this allows you to translate them.

[New feature] Add "field html" in class-wpml-elementor-form.php

Hello,

Could you add "field-html" in class-wpml-elementor-form.php to enable the possibility to translate html form fields.

Best Regards.

---

public function get_fields() {
return array( 'field_label', 'placeholder', 'field_options', 'field_html' );
}

---

protected function get_title( $field ) {
switch( $field ) {
.....
case 'field_html':
return esc_html_( 'Form: Field html', 'wpml-string-translation' );_

---

protected function get_editor_type( $field ) {
switch( $field ) {
.....
case 'field_html':
return 'VISUAL';

[Feature/ Improvement] Add the ability to translate the Elementor "Icon Box" Link

When adding the Elementor Icon Box element (icon-box), you can specify a link.
That link is then not available for translation and it is copied to the translation.
As you can see in https://github.com/OnTheGoSystems/wpml-page-builders-elementor/blob/master/src/class-wpml-elementor-translatable-nodes.php#L339 we have only two elements there and the link element is not one of them.

Multiple URL fields not working

Related to: elementor/elementor#6786

We found out an issue where multiple URL fields cannot be translated.

Example code that is not working:

add_filter('wpml_elementor_widgets_to_translate', function($widgets) {
    $widgets['example_name] = [
        'conditions' => ['widgetType' => 'example_name'],
        'fields' => [
            'url_field_1' => [
                'field' => 'url',
                'type' => __('Example URL Field 1', 'trailactive'),
                'editor_type' => 'LINE', // or 'LINK' but relative links not possible that way
            ],
            'url_field_2' => [
                'field' => 'url',
                'type' => __('Example URL Field 2', 'trailactive'),
                'editor_type' => 'LINE', // or 'LINK' but relative links not possible that way
            ],
        ],
    ];
    return $widgets;
});

I have found the issue to be inside of the class-wpml-elementor-translatable-nodes.phpfile.

To fix the issue, we can set $field['field'] to something like "{$key}_{$field_key}" before calling the get_string_name() function in get() and update() (only when !is_numeric($key)). I have tested this change and it seems to work fine now!

I can create a Pull Request if that would be helpful?

Elementor image-box -> description - adds an extra paragraph tag

The Elementor element image-box has two fields - title and description.
The title is set to "Line" type, but the description is set to "Visual" type.
Because it is set to "Visual", when translated, in the translation there is an extra paragraph (

) tag and the element contents are actually outside of the proper tag.

If we change the element type to "Line" for the description - there is no issue, but then you miss the fine controls in the translation editor - which is a minus.