GithubHelp home page GithubHelp logo

Comments (11)

elia avatar elia commented on July 18, 2024

That would be awesome

from opal-rspec.

wied03 avatar wied03 commented on July 18, 2024

@elia - Started @ https://github.com/wied03/opal-rspec/tree/features/rspec_specs, based on the code @ #33. I think doing this first will make migrating to 3.2/3.3 easier since we'll know more about whether our foundation is solid.

from opal-rspec.

wied03 avatar wied03 commented on July 18, 2024

@elia - Finally got the browser to at least run rspec-core's specs with several exclusions and patches. Thus far this has produced 1 fix and better documentation about what's not supported.

735 examples, 384 failures, 1 pending

Still more work to do, but it's a start

from opal-rspec.

wied03 avatar wied03 commented on July 18, 2024

@elia - Making slow but steady progress on the rspec-core specs, which are probably much tougher than the expectations or mocks specs. The effort has already produced 2 fixes for Opal itself plus 2 issues in opal-rspec I didn't know about.

I think getting the rspec-core, expectations, and mocks specs running (with unsupportable items filtered) for version 0.5.0 is a good goal. What do you think?

from opal-rspec.

elia avatar elia commented on July 18, 2024

I think you're doing a tremendous job!

from opal-rspec.

wied03 avatar wied03 commented on July 18, 2024

@elia - I'm down to 14 unexpected failures on the rspec-core specs and 265 (out of 1509 passing) for rspec-expectations specs.

Given the amount of time to get to that point (and what I would consider a big improvement over 0.4's setup), I think it's best to spend less time trying to fix everything and instead just get to a stopping point by documenting what works. By that I mean put tests that really ought to pass in a filter/bugs/** file and then put what we know doesn't work in the README. Then this can get released (as 0.5) and people can benefit from the improvements that have already been made while the remaining pieces are whittled away.

Sound good?

from opal-rspec.

wied03 avatar wied03 commented on July 18, 2024

I went ahead with that approach, but I did try and fix issues when I could. Now the core, support, and expectation specs all "pass" with some exclusions. Working on the mock specs now.

from opal-rspec.

elia avatar elia commented on July 18, 2024

w00t!

from opal-rspec.

wied03 avatar wied03 commented on July 18, 2024

Right now mocks is a pain because any_instance_of wipes out the entire Example class. More generally though, if nothing else, we'll now have a much better idea (and I've been updating the README) about what works and what doesn't. Plus rspec uses so many aspects of the Ruby language that it caused all of these PRs I've been submitting to be teased out.

from opal-rspec.

wied03 avatar wied03 commented on July 18, 2024

Investigation is over, it's done :)

from opal-rspec.

elia avatar elia commented on July 18, 2024

🎩

from opal-rspec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.