GithubHelp home page GithubHelp logo

Async specs shortcomings about opal-rspec HOT 5 CLOSED

meh avatar meh commented on August 17, 2024
Async specs shortcomings

from opal-rspec.

Comments (5)

adambeynon avatar adambeynon commented on August 17, 2024

@meh is this still relevant?

from opal-rspec.

wied03 avatar wied03 commented on August 17, 2024

@meh - another thing i've noticed is that the reporter summary totals don't include failed async tests and the exit status of the text formatter/rake task doesn't include a failure if these fail. Maybe we could refactor these to use a Jasmine like approach, which uses a done object passed to the async block and the runner can asynchronously wait (check in periodically for the done call)? On a related note, the AsyncRunner class doesn't seem to be fully used to actually run the specs either. I removed it from the code and the specs all passed (just the summary broke).

from opal-rspec.

wied03 avatar wied03 commented on August 17, 2024

Actually, re: the last sentence on my last comment, the only reason the summary broke was because when I yanked out the AsyncRunner, I took this block with it:

run_async_examples do
   self.finish
end

It appears the AsyncRunner was not doing anything.

from opal-rspec.

wied03 avatar wied03 commented on August 17, 2024

See #17

from opal-rspec.

wied03 avatar wied03 commented on August 17, 2024

@adambeynon @meh - I think this can also be closed since master has refactored this.

from opal-rspec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.