DIS7.xml RecordQueryReliablePdu value about open-dis-java

[mcgredonps]

Nicely spotted. Fixed in the actual XML repo I missed last night, at DISDescription here in the open-dis github project.

In the Java implementation it's somewhat dangerous to re-generate the source code, so I fixed that directly without a regeneration. There are various patches that can be made to the generated code when what the protocol does differs from the generation basics. That can be done as a Unix patch operation, but that's kinda unreliable.

[leif81]

In the Java implementation it's somewhat dangerous to re-generate the source code,

Don, I'm glad you said that!

There's obviously a lot of effort saved by the code generator. However I too have been thinking about how painful it'd be if we were to regenerate the Java code at this point, given all the hand made improvements we've made 😨 . The junit tests would be an alarm bell, they would either fail to compile or fail to pass. However it would still be a pretty large task to reapply the cumulative changes to get to a point where the tests pass again.

It sounds like you already agree, but maybe the best strategy is to use the code generator once for the initial library creation, and then from that point on just hand edit the source code like we are now?

[leif81]

Fixed by @mcgredonps here

open-dis/dis-description@6bf1928

[mcgredonps]

The link that shows up on the page at open-dis-java is now DISDescription @ 6ff1b08<https://github.com/open-dis/DISDescription/tree/6ff1b0889dcf6053cf654f07f4773ff67ae48109> ; is it the case that the open-dis-java link is going to the most recent version at DISDescription, or is that going to an older, un-updated version? I thought if I just fixed the content at the DISDescription repo it would automatically be updated at for example open-dis-java. On May 18, 2017, at 5:44 AM, Leif Gruenwoldt <[email protected]<mailto:[email protected]>> wrote: Fixed by @mcgredonps<https://github.com/mcgredonps> here open-dis/dis-description@6bf1928<open-dis/dis-description@6bf1928> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#35 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADBlZt9CvyfPRCpEihJLSMmNoSXIVRSyks5r7D1BgaJpZM4NO4bu>.

[leif81]

git submodules are a bit funny. The DISDescription submodule in open-dis-java won't automatically point at the latest commit because it's actually locked to an earlier commit (by design). It would need to be updated manually. This is both a blessing and a curse! I personally limit my use of submodules these days because of the headaches they've caused me!

[mcgredonps]

Huh. Interesting, but I suppose you can make the argument that pointing at another repo is always going to be pointing at a specific version, rather than whatever is latest. In contrast to the ancient stuff in the SVN world, where you just pointed it at the latest. Now I gotta run through any other languages and make sure they point at the latest. On May 18, 2017, at 11:43 AM, Leif Gruenwoldt <[email protected]<mailto:[email protected]>> wrote: git submodules are a bit funny. The DISDescription submodule in open-dis-java won't automatically point at the latest commit because it's actually locked to an earlier commit (by design). It would need to be updated manually. This is both a blessing and a curse! I personally limit my use of submodules these days because of the headaches they've caused me! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#35 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADBlZiN1LsJVfjbG-EF25iuo611OerICks5r7JFrgaJpZM4NO4bu>.