open-dollar / od-relayer Goto Github PK

to avoid confusion now that repo containers other types of relayers

Test Relayers from CamelotPool

Multiple GA tests are failing

Required to calculate TVL deposit information

ODG mainnet camelot pool: 0xF935263c9950EB2881FF58Bd6a76c3D2564A78D5

Audit

https://ethereum.stackexchange.com/questions/98685/computing-the-uniswap-v3-pair-price-from-q64-96-number

https://blog.uniswap.org/uniswap-v3-math-primer

Todo:
After initializing value of liquidity pool, use following calculations to confirm correct value:

    sqrtPriceX96 = sqrt(price) * 2 ** 96
    # divide both sides by 2 ** 96
    sqrtPriceX96 / (2 ** 96) = sqrt(price)
    # square both sides
    (sqrtPriceX96 / (2 ** 96)) ** 2 = price
    # expand the squared fraction
    (sqrtPriceX96 ** 2) / ((2 ** 96) ** 2)  = price
    # multiply the exponents in the denominator to get the final expression
    sqrtRatioX96 ** 2 / 2 ** 192 = price
    ```

use a mapping

Requires mocking the Chainlink sequencer feed to test scenario where the sequencer is down.

Proxy which consumes both chainlink and teller data, and will fail to return isValid if the prices differ by more than a certain percentage.

Related to #50

Unit tests

Reference to issue #8

Modify relayer so that baseToken is read and it is not assumed the it is an 18 decimal token.

Unit tests

https://blog.uniswap.org/uniswap-v3-math-primer

Oracle test for down-versioned

• Algebra relayer
• Chainlink relayer
• denominated oracle

ChainlinkRelayerWithL2Validity.getResultWithValidity function is designed to not revert, when result is not valid, it should just return false as validity. But in case if sequencer is down, then function reverts, which may revert integrations.

function getResultWithValidity() public view override returns (uint256 _result, bool _validity) {
    require(getSequencerFeedValidation(), 'SequencerDown');
    (_result, _validity) = super.getResultWithValidity();
  }

od-contracts has actions set up to run on PRs, but od-relayer does not.

Expected outcome:
od-relayer repo should have similar setup and Github Actions as od-contracts

• Only the relayer should be initialized.
• Remove pool creation (will be created manually using the app)
• Remove add liquidity

• add versioned denominated oracle factory
• add versioned chainlink oracle factory
• update post-oracle setup script

https://github.com/open-dollar/od-relayer/actions/runs/7278216524/job/19831929757

Encountered 1 failing test in test/e2e/SystemOracle.s.sol:OracleSetup
[FAIL. Reason: setup failed: invalid rpc url: ] setUp() (gas: 0)

Required to calculate TVL deposit information

See here for the list of oracle addresses open-dollar/od-sdk#56

RETH

1. ChainlinkRelayer RETH / ETH
2. DenominatedOracle (RETH / ETH) * (ETH / USD)

WSTETH

1. ChainlinkRelayer WSTETH / ETH
2. DenominatedOracle (WSTETH / ETH) * (ETH / USD)

check access control

ChainlinkRelayerWithL2Validity extends ChainlinkRelayer and provides L2 sequencer check. Currently it can't be deployed with ChainlinkRelayerFactory and there is not separate factory for it, as ChainlinkRelayerFactory allows to deploy ChainlinkRelayerChild only, which is ChainlinkRelayer.

  function deployChainlinkRelayer(
    address _aggregator,
    uint256 _staleThreshold
  ) external isAuthorized returns (IBaseOracle _chainlinkRelayer) {
    _chainlinkRelayer = IBaseOracle(address(new ChainlinkRelayerChild(_aggregator, _staleThreshold)));
    relayerId++;
    relayerById[relayerId] = address(_chainlinkRelayer);
    emit NewChainlinkRelayer(address(_chainlinkRelayer), _aggregator, _staleThreshold);
  }

open-dollar/od-contracts@3be9546

Problem:
token0 and token1 are unrelated to arg input, but ordered by size. When SystemCoin address changes (after new deployed), it can break test setup by changing the token order.

Todo:

• add check and accommodate tests to dynamic token order in pool

Same as Camelot issue, but for the ChainlinkRelayer
ref issue #233

Price reads from SystemCoinOracle are over by 1 Ether order of magnitude